[FLINK-5524] Support early out for code generated conjunctive conditions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.4, 1.2.0, 1.3.0
• Fix Version/s: 1.3.0
• Component/s: Table SQL / API
• Assignee: Kurt Young
• Reporter: Fabian Hueske
• Created: 17/Jan/17 11:28
• Updated: 02/Mar/17 15:19
• Resolved: 02/Mar/17 15:19

Description

Currently, all nested conditions for a conjunctive predicate are evaluated before the conjunction is checked.

A condition like (v1 == v2) && (v3 < 5) would be compiled into

boolean res1;
if (v1 == v2) {
  res1 = true;
} else {
  res1 = false;
}

boolean res2;
if (v3 < 5) {
  res2 = true;
} else {
  res2 = false;
}

boolean res3;
if (res1 && res2) {
  res3 = true;
} else {
  res3 = false;
}

if (res3) {
  // emit something
}

It would be better to leave the generated code as early as possible, e.g., with a return instead of res1 = false. The code generator needs a bit of context information for that.

Issue Links

• links to: GitHub Pull Request #3372