Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5521

remove unused KvStateRequestSerializer#serializeList

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Queryable State
    • Labels:
      None

      Description

      KvStateRequestSerializer#serializeList is unused and instead the state backends' serialisation functions are used. Therefore, remove this one and make sure KvStateRequestSerializer#deserializeList works with the state backends' ones.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3135

          FLINK-5521 remove unused KvStateRequestSerializer#serializeList

          Also make sure that the serialization via the state backends' list states
          matches the deserialization of the KvStateRequestSerializer#deserializeList
          method.
          So far, it was used this way but not made sure via tests.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5521

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3135.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3135


          commit 26a741a7c844b4af7dc4bd05e314d53882668660
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-01-17T10:23:32Z

          FLINK-5521 remove unused KvStateRequestSerializer#serializeList

          Also make sure that the serialization via the state backends' list states
          matches the deserialization of the KvStateRequestSerializer#deserializeList
          method.
          So far, it was used this way but not made sure via tests.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3135 FLINK-5521 remove unused KvStateRequestSerializer#serializeList Also make sure that the serialization via the state backends' list states matches the deserialization of the KvStateRequestSerializer#deserializeList method. So far, it was used this way but not made sure via tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5521 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3135 commit 26a741a7c844b4af7dc4bd05e314d53882668660 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-01-17T10:23:32Z FLINK-5521 remove unused KvStateRequestSerializer#serializeList Also make sure that the serialization via the state backends' list states matches the deserialization of the KvStateRequestSerializer#deserializeList method. So far, it was used this way but not made sure via tests.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3135

          Good fix, thanks!

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3135 Good fix, thanks! Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3135

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3135
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via d3a16d298a781e2af45c3577fd8bbb3b81a04259
          • 1.3.0 via d8fd04a7e72ecee4fe5b06f42ee9530aa292e644
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via d3a16d298a781e2af45c3577fd8bbb3b81a04259 1.3.0 via d8fd04a7e72ecee4fe5b06f42ee9530aa292e644

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development