Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5519

scala-maven-plugin version all change to 3.2.2

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Build System
    • Labels:
      None

      Description

      1. scala-maven-plugin version all change to 3.2.2 in all module
      2. parent pom version change to apache-18 from apache-14

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user shijinkui opened a pull request:

          https://github.com/apache/flink/pull/3132

          FLINK-5519 [build] scala-maven-plugin version all change to 3.2.2

          1. scala-maven-plugin version all change to 3.2.2 in all module
          2. parent pom version change to apache-18 from apache-14

          • [X] General
          • The pull request references the related JIRA issue ("FLINK-5519 scala-maven-plugin version all change to 3.2.2")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [X] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [X] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/shijinkui/flink FLINK-5519_scala-maven-plugin

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3132.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3132


          commit d583bf6038c2ffa5a50f7dd4bcc53815ed4cb003
          Author: shijinkui <shijinkui@huawei.com>
          Date: 2017-01-17T07:10:52Z

          FLINK-5519 [build] scala-maven-plugin version all change to 3.2.2


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3132 FLINK-5519 [build] scala-maven-plugin version all change to 3.2.2 1. scala-maven-plugin version all change to 3.2.2 in all module 2. parent pom version change to apache-18 from apache-14 [X] General The pull request references the related JIRA issue (" FLINK-5519 scala-maven-plugin version all change to 3.2.2") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [X] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [X] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/shijinkui/flink FLINK-5519 _scala-maven-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3132.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3132 commit d583bf6038c2ffa5a50f7dd4bcc53815ed4cb003 Author: shijinkui <shijinkui@huawei.com> Date: 2017-01-17T07:10:52Z FLINK-5519 [build] scala-maven-plugin version all change to 3.2.2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3132

          Good idea to upgrade the scala plugin. But with this change, it does not define a version at all.
          I think it would need to be added to the "plugin management" section.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Good idea to upgrade the scala plugin. But with this change, it does not define a version at all. I think it would need to be added to the "plugin management" section.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3132

          @StephanEwen There already is an entry for `scala-maven-plugin` in the plugin management section.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3132 @StephanEwen There already is an entry for `scala-maven-plugin` in the plugin management section.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3132

          Okay, good.
          Then I think this is probably good to merge.

          @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Okay, good. Then I think this is probably good to merge. @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3132

          I think its fine (as long as we are not merging it to the 1.2 release branch)

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3132 I think its fine (as long as we are not merging it to the 1.2 release branch)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on the issue:

          https://github.com/apache/flink/pull/3132

          > @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc?

          @StephanEwen There's no effect to the create_release_files.sh in my opinion.
          from v14 to v18, there are some plugins' version upgrade.

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3132 > @rmetzger Any reservations that the upgrade to the Apache Parent POM v18 has implications on release scripts, etc? @StephanEwen There's no effect to the create_release_files.sh in my opinion. from v14 to v18, there are some plugins' version upgrade.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3132#discussion_r96582962

          — Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml —
          @@ -313,7 +313,6 @@ under the License.
          <plugin>
          <groupId>net.alchim31.maven</groupId>
          <artifactId>scala-maven-plugin</artifactId>

          • <version>3.1.4</version>
              • End diff –

          I think you an not remove the version here. Where does the generated project get the plugin version from?

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/3132#discussion_r96582962 — Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml — @@ -313,7 +313,6 @@ under the License. <plugin> <groupId>net.alchim31.maven</groupId> <artifactId>scala-maven-plugin</artifactId> <version>3.1.4</version> End diff – I think you an not remove the version here. Where does the generated project get the plugin version from?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user shijinkui commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3132#discussion_r96585227

          — Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml —
          @@ -313,7 +313,6 @@ under the License.
          <plugin>
          <groupId>net.alchim31.maven</groupId>
          <artifactId>scala-maven-plugin</artifactId>

          • <version>3.1.4</version>
              • End diff –

          have fix it. Thanks for review

          Show
          githubbot ASF GitHub Bot added a comment - Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3132#discussion_r96585227 — Diff: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml — @@ -313,7 +313,6 @@ under the License. <plugin> <groupId>net.alchim31.maven</groupId> <artifactId>scala-maven-plugin</artifactId> <version>3.1.4</version> End diff – have fix it. Thanks for review
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3132

          Looks good, thanks. merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3132 Looks good, thanks. merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3132

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3132
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in a18657dcc5ac2411595481fd0983585465383808

          Thank you for the contribution!

          Show
          StephanEwen Stephan Ewen added a comment - Fixed in a18657dcc5ac2411595481fd0983585465383808 Thank you for the contribution!

            People

            • Assignee:
              shijinkui shijinkui
              Reporter:
              shijinkui shijinkui
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development