Details

      Description

      The queryable state "sink" using ListState
      (".asQueryableState(<name>, ListStateDescriptor)") stores all incoming data forever and is never cleaned. Eventually, it will pile up too much memory and is thus of limited use.

      We should remove it from the API.

        Issue Links

          Activity

          Hide
          uce Ufuk Celebi added a comment -

          +1

          Would you like to do that and open a PR?

          Show
          uce Ufuk Celebi added a comment - +1 Would you like to do that and open a PR?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3129

          FLINK-5507 remove KeyedStream#asQueryableState(name, ListStateDescriptor<T>)

          The queryable state "sink" using ListState stores all incoming data forever and is never cleaned. Eventually, it will pile up too much memory and is thus of limited use.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5507

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3129.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3129


          commit 9723363951557647a8a060d61e99eefda3b23bfc
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-01-16T12:36:02Z

          FLINK-5507 remove KeyedStream#asQueryableState(name, ListStateDescriptor<T>)

          The queryable state "sink" using ListState stores all incoming data forever and is never cleaned. Eventually, it will pile up too much memory and is thus of limited use.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3129 FLINK-5507 remove KeyedStream#asQueryableState(name, ListStateDescriptor<T>) The queryable state "sink" using ListState stores all incoming data forever and is never cleaned. Eventually, it will pile up too much memory and is thus of limited use. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5507 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3129 commit 9723363951557647a8a060d61e99eefda3b23bfc Author: Nico Kruber <nico@data-artisans.com> Date: 2017-01-16T12:36:02Z FLINK-5507 remove KeyedStream#asQueryableState(name, ListStateDescriptor<T>) The queryable state "sink" using ListState stores all incoming data forever and is never cleaned. Eventually, it will pile up too much memory and is thus of limited use.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3129

          Looks good. Will merge as soon as Travis passes.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3129 Looks good. Will merge as soon as Travis passes.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3129

          Build failure is unrelated. Merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3129 Build failure is unrelated. Merging.
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 1c8a48f (release-1.2), 63a6af3 (master).

          Show
          uce Ufuk Celebi added a comment - Fixed in 1c8a48f (release-1.2), 63a6af3 (master).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3129

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3129

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development