Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5503

mesos-appmaster.sh script could print return value message

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Mesos
    • Labels:
      None

      Description

      The mesos-appmaster.sh does not print an error message if the return value of MesosApplicationMasterRunner is nonzero. This could help the user to realize that something went wrong.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3162

          FLINK-5503 [log] Print error message in case MesosApplicationMaster Runner fails

          This PR is based on #3159.

          This PR adds an error message to the mesos-appmaster.sh script which is printed in case
          that the MesosApplicationMasterRunner fails.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink mesosReturnValue

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3162.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3162


          commit 19143548ab2a3a856d19436d6d3abed7d6700229
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-01-18T15:53:42Z

          FLINK-5504 Create mesos-appmaster log file in log directory

          This PR prepends the FLINK_LOG_DIR env variable pointing to Flink's logging
          directory to the logging file name.

          commit 5c0aae51f3122780d1b170edcdcf66d43a0feb1d
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-01-18T16:36:33Z

          FLINK-5503 [log] Print error message in case MesosApplicationMasterRunner fails

          This PR adds an error message to the mesos-appmaster.sh script which is printed in case
          that the MesosApplicationMasterRunner fails.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3162 FLINK-5503 [log] Print error message in case MesosApplicationMaster Runner fails This PR is based on #3159. This PR adds an error message to the mesos-appmaster.sh script which is printed in case that the MesosApplicationMasterRunner fails. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink mesosReturnValue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3162.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3162 commit 19143548ab2a3a856d19436d6d3abed7d6700229 Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-01-18T15:53:42Z FLINK-5504 Create mesos-appmaster log file in log directory This PR prepends the FLINK_LOG_DIR env variable pointing to Flink's logging directory to the logging file name. commit 5c0aae51f3122780d1b170edcdcf66d43a0feb1d Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-01-18T16:36:33Z FLINK-5503 [log] Print error message in case MesosApplicationMasterRunner fails This PR adds an error message to the mesos-appmaster.sh script which is printed in case that the MesosApplicationMasterRunner fails.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3162

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3162 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3162

          Thanks for the review @fhueske. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3162 Thanks for the review @fhueske. Merging this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3162

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3162
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via 33780ef4f9ffde5151aa5e86018fdd1855a9e47f

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via 33780ef4f9ffde5151aa5e86018fdd1855a9e47f

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development