Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5489

maven release:prepare fails due to invalid JDOM comments in pom.xml

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Build System
    • Labels:

      Description

      When I was trying to publish Flink to our internal artifactory, I found out that maven release:prepare has failed because the plugin complains about the some of the comments pom.xml do not conform with the JDOM format:

      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.4.2:prepare (default-cli) on project flink-parent: Execution default-cli of goal org.apache.maven.plugins:maven-release-plugin:2.4.2:prepare failed: The data "-
      [ERROR] This module is used a dependency in the root pom. It activates shading for all sub modules
      [ERROR] through an include rule in the shading configuration. This assures that Maven always generates
      [ERROR] an effective pom for all modules, i.e. get rid of Maven properties. In particular, this is needed
      [ERROR] to define the Scala version property in the root pom but not let the root pom depend on Scala
      [ERROR] and thus be suffixed along with all other modules.
      [ERROR] " is not legal for a JDOM comment: Comment data cannot start with a hyphen.
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user haohui opened a pull request:

          https://github.com/apache/flink/pull/3123

          FLINK-5489 maven release:prepare fails due to invalid JDOM comments…

          When I was trying to publish Flink to our internal artifactory, I found out that maven release:prepare has failed because the plugin complains about the some of the comments pom.xml do not conform with the JDOM format (More information on the JIRA).

          This PR fixes the issue by making all comments conform to the JDOM format.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/haohui/flink FLINK-5489

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3123.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3123


          commit ba26954891b4ce1d968a90e7c89a04681dca6b65
          Author: Haohui Mai <haohui@uber.com>
          Date: 2017-01-13T22:48:35Z

          FLINK-5489 maven release:prepare fails due to invalid JDOM comments in pom.xml.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/3123 FLINK-5489 maven release:prepare fails due to invalid JDOM comments… When I was trying to publish Flink to our internal artifactory, I found out that maven release:prepare has failed because the plugin complains about the some of the comments pom.xml do not conform with the JDOM format (More information on the JIRA). This PR fixes the issue by making all comments conform to the JDOM format. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haohui/flink FLINK-5489 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3123 commit ba26954891b4ce1d968a90e7c89a04681dca6b65 Author: Haohui Mai <haohui@uber.com> Date: 2017-01-13T22:48:35Z FLINK-5489 maven release:prepare fails due to invalid JDOM comments in pom.xml.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3123

          Good change. Thank you.

          I'll merge it right away

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3123 Good change. Thank you. I'll merge it right away
          Hide
          rmetzger Robert Metzger added a comment -

          Thank you for fixing this!

          Resolved in master with commit http://git-wip-us.apache.org/repos/asf/flink/commit/e2ba042c

          Show
          rmetzger Robert Metzger added a comment - Thank you for fixing this! Resolved in master with commit http://git-wip-us.apache.org/repos/asf/flink/commit/e2ba042c
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3123

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3123

            People

            • Assignee:
              wheat9 Haohui Mai
              Reporter:
              wheat9 Haohui Mai
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development