Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5485

Mark compiled web frontend files as binary when processed by git diff

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      Particularly beneficial now that javascript is minified, we can mark compiled web frontend files as binary when processed by git diff.
      https://linux.die.net/man/5/gitattributes

      This does not affect how files are displayed by github.

        Issue Links

          Activity

          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via 6b3c683450eb7aee1c9c65be75a0fddb06cea2ce
          • 1.3.0 via faee74ed8ba2476117b6c9e56932b3541f69ac5c
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via 6b3c683450eb7aee1c9c65be75a0fddb06cea2ce 1.3.0 via faee74ed8ba2476117b6c9e56932b3541f69ac5c
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3122

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3122
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3122

          +1

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3122 +1 Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rmetzger commented on the issue:

          https://github.com/apache/flink/pull/3122

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3122 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3122

          +1 makes sense. Would you mind merging this to release-1.2 and release-1.1 as well?

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3122 +1 makes sense. Would you mind merging this to release-1.2 and release-1.1 as well?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3122

          FLINK-5485 [webfrontend] Mark compiled web frontend files as binary when processed by git diff

          Particularly beneficial now that javascript is minified, we can mark compiled web frontend files as binary when processed by git diff.
          https://linux.die.net/man/5/gitattributes

          This does not affect how files are displayed by github.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 5485_mark_compiled_web_frontend_files_as_binary_when_processed_by_git_diff

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3122.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3122


          commit ace0272f9c3abc60645f2119744e88afa975a731
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-01-13T18:33:29Z

          FLINK-5485 [webfrontend] Mark compiled web frontend files as binary when processed by git diff

          Particularly beneficial now that javascript is minified, we can mark
          compiled web frontend files as binary when processed by git diff.
          https://linux.die.net/man/5/gitattributes

          This does not affect how files are displayed by github.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3122 FLINK-5485 [webfrontend] Mark compiled web frontend files as binary when processed by git diff Particularly beneficial now that javascript is minified, we can mark compiled web frontend files as binary when processed by git diff. https://linux.die.net/man/5/gitattributes This does not affect how files are displayed by github. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 5485_mark_compiled_web_frontend_files_as_binary_when_processed_by_git_diff Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3122.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3122 commit ace0272f9c3abc60645f2119744e88afa975a731 Author: Greg Hogan <code@greghogan.com> Date: 2017-01-13T18:33:29Z FLINK-5485 [webfrontend] Mark compiled web frontend files as binary when processed by git diff Particularly beneficial now that javascript is minified, we can mark compiled web frontend files as binary when processed by git diff. https://linux.die.net/man/5/gitattributes This does not affect how files are displayed by github.

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development