Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5461

Remove Superflous TypeInformation Declaration

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Gelly
    • Labels:
      None

      Description

      FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3096

          FLINK-5461 [gelly] Remove Superflous TypeInformation Declaration

          FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 5461_remove_superflous_typeinformation_declaration

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3096.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3096


          commit 55ae204beb013fe567ee427265d4b0400f96447e
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-01-11T18:43:58Z

          FLINK-5461 [gelly] Remove Superflous TypeInformation Declaration

          FLINK-4624 updated Gelly's Summarization algorithm to use
          Either<NullValue, VV> in order to support types for which the
          serialization does not support null values. This required the use of
          explicit TypeInformation due to TypeExtractor. FLINK-4673 created a
          TypeInfoFactory for EitherType so the explicit TypeInformation can be
          removed.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3096 FLINK-5461 [gelly] Remove Superflous TypeInformation Declaration FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 5461_remove_superflous_typeinformation_declaration Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3096.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3096 commit 55ae204beb013fe567ee427265d4b0400f96447e Author: Greg Hogan <code@greghogan.com> Date: 2017-01-11T18:43:58Z FLINK-5461 [gelly] Remove Superflous TypeInformation Declaration FLINK-4624 updated Gelly's Summarization algorithm to use Either<NullValue, VV> in order to support types for which the serialization does not support null values. This required the use of explicit TypeInformation due to TypeExtractor. FLINK-4673 created a TypeInfoFactory for EitherType so the explicit TypeInformation can be removed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3096

          Looks good, thanks.

          +1 to merge this

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3096 Looks good, thanks. +1 to merge this
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3096

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3096
          Hide
          greghogan Greg Hogan added a comment -

          Implemented in b408d61f707806d2a188c55065d1187f4f05099a

          Show
          greghogan Greg Hogan added a comment - Implemented in b408d61f707806d2a188c55065d1187f4f05099a

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development