Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      When fixing https://issues.apache.org/jira/browse/FLINK-5144, we actually copied some classes from Calcite and do a quick fix in Flink. The fixing is actually merged by Calcite and will be included in version 1.12, we should update the Calcite version and remove the classes we copied.
      The classes we copied:
      1. FlinkAggregateJoinTransposeRule
      2. RelDecorrelator -> FlinkRelDecorrelator

        Issue Links

          Activity

          Hide
          anmu Anton Mushin added a comment - - edited

          Hi.
          We have problem in FLINK-4604 with calcite rule. In PR for FLINK-4604 I use work around - the copy of rule inside Flink with changes.
          For fix the problem in calcite I created jira issue: CALCITE-1621
          I think that will be correct clean up the FlinkAggregateReduceFunctionsRule in this issue.
          What do you think about it?

          Show
          anmu Anton Mushin added a comment - - edited Hi. We have problem in FLINK-4604 with calcite rule. In PR for FLINK-4604 I use work around - the copy of rule inside Flink with changes. For fix the problem in calcite I created jira issue: CALCITE-1621 I think that will be correct clean up the FlinkAggregateReduceFunctionsRule in this issue. What do you think about it?
          Hide
          fhueske Fabian Hueske added a comment -

          Hi Anton Mushin,

          I think it certainly makes sense to keep an eye on CALCITE-1621 and apply the same fixed to the copied rule in Flink's code base.
          The Calcite community should know best how to fix the issue.
          Thanks for pointing to CALCITE-1621.

          Best, Fabian

          Show
          fhueske Fabian Hueske added a comment - Hi Anton Mushin , I think it certainly makes sense to keep an eye on CALCITE-1621 and apply the same fixed to the copied rule in Flink's code base. The Calcite community should know best how to fix the issue. Thanks for pointing to CALCITE-1621 . Best, Fabian
          Hide
          ykt836 Kurt Young added a comment -

          Hi Anton Mushin,

          Thanks for pointing this out, i will pay attention to CALCITE-1621 after calcite release, and only remove the rule when both issues are fixed.

          Show
          ykt836 Kurt Young added a comment - Hi Anton Mushin , Thanks for pointing this out, i will pay attention to CALCITE-1621 after calcite release, and only remove the rule when both issues are fixed.
          Hide
          twalthr Timo Walther added a comment -

          Kurt Young We updated the Calcite version. Would be great if you could open a PR for this issue or unassign it.

          Show
          twalthr Timo Walther added a comment - Kurt Young We updated the Calcite version. Would be great if you could open a PR for this issue or unassign it.
          Hide
          ykt836 Kurt Young added a comment -

          Timo Walther Sure, i will open a PR soon.

          Show
          ykt836 Kurt Young added a comment - Timo Walther Sure, i will open a PR soon.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user KurtYoung opened a pull request:

          https://github.com/apache/flink/pull/3689

          FLINK-5435 [table] Remove FlinkAggregateJoinTransposeRule and Flink…

          …RelDecorrelator after calcite updated to 1.12

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/KurtYoung/flink flink-5435

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3689.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3689


          commit 6c4fb2f5a655129c178fdf543f64b240b3012e8b
          Author: Kurt Young <ykt836@gmail.com>
          Date: 2017-04-06T14:06:51Z

          FLINK-5435 [table] Remove FlinkAggregateJoinTransposeRule and FlinkRelDecorrelator after calcite updated to 1.12


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user KurtYoung opened a pull request: https://github.com/apache/flink/pull/3689 FLINK-5435 [table] Remove FlinkAggregateJoinTransposeRule and Flink… …RelDecorrelator after calcite updated to 1.12 You can merge this pull request into a Git repository by running: $ git pull https://github.com/KurtYoung/flink flink-5435 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3689.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3689 commit 6c4fb2f5a655129c178fdf543f64b240b3012e8b Author: Kurt Young <ykt836@gmail.com> Date: 2017-04-06T14:06:51Z FLINK-5435 [table] Remove FlinkAggregateJoinTransposeRule and FlinkRelDecorrelator after calcite updated to 1.12
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3689

          Thanks for the PR @KurtYoung.
          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3689 Thanks for the PR @KurtYoung. +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3689

          Merging

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3689 Merging
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed by c5173fa26d3d8a32b0b182a37d34a8eeff6e36d0

          Show
          fhueske Fabian Hueske added a comment - Fixed by c5173fa26d3d8a32b0b182a37d34a8eeff6e36d0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3689

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3689

            People

            • Assignee:
              ykt836 Kurt Young
              Reporter:
              ykt836 Kurt Young
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development