Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5427

Typo in the event_timestamps_watermarks doc

    Details

      Description

      I was reading the watermark doc: https://ci.apache.org/projects/flink/flink-docs-release-1.2/dev/event_timestamps_watermarks.html
      We should replace element with lastElement in the body of method checkAndGetNextWatermark:

      public Watermark checkAndGetNextWatermark(MyEvent lastElement, long extractedTimestamp) {
      		return element.hasWatermarkMarker() ? new Watermark(extractedTimestamp) : null;
      	}
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user barcahead opened a pull request:

          https://github.com/apache/flink/pull/3082

          FLINK-5427[docs]replace element with lastElement

          typo in event_timestamps_watermarks doc

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/barcahead/flink master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3082.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3082


          commit fea9e56b8ba2733160eb400d6b52bfc8c714f741
          Author: fengyelei 00406569 <fengyelei@huawei.com>
          Date: 2017-01-09T10:37:59Z

          FLINK-5427[docs]replace element with lastElement


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user barcahead opened a pull request: https://github.com/apache/flink/pull/3082 FLINK-5427 [docs] replace element with lastElement typo in event_timestamps_watermarks doc You can merge this pull request into a Git repository by running: $ git pull https://github.com/barcahead/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3082.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3082 commit fea9e56b8ba2733160eb400d6b52bfc8c714f741 Author: fengyelei 00406569 <fengyelei@huawei.com> Date: 2017-01-09T10:37:59Z FLINK-5427 [docs] replace element with lastElement
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3082

          Thanks for noticing and fixing this!
          Merging...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3082 Thanks for noticing and fixing this! Merging...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3082

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3082
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via 1750b0dda8c243a215dcd558baf36ea1053a4310
          • 1.3.0 via 03b62ae50ea97f48a845c2dddd6733c6defd4090
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via 1750b0dda8c243a215dcd558baf36ea1053a4310 1.3.0 via 03b62ae50ea97f48a845c2dddd6733c6defd4090

            People

            • Assignee:
              Unassigned
              Reporter:
              barcahead Yelei Feng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development