Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Documentation
    • Labels:
      None

      Description

      As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user WangTaoTheTonic opened a pull request:

          https://github.com/apache/flink/pull/3071

          FLINK-5417[DOCUMENTATION]correct the wrong config file name

          As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/WangTaoTheTonic/flink outdate

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3071.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3071


          commit 8c927bda55fead6b4cc90f49151c19907ac3700f
          Author: WangTaoTheTonic <wangtao111@huawei.com>
          Date: 2017-01-06T04:12:31Z

          fix the wrong config file name


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user WangTaoTheTonic opened a pull request: https://github.com/apache/flink/pull/3071 FLINK-5417 [DOCUMENTATION] correct the wrong config file name As the config file name is conf/flink-conf.yaml, the usage "conf/flink-config.yaml" in document is wrong and easy to confuse user. We should correct them. You can merge this pull request into a Git repository by running: $ git pull https://github.com/WangTaoTheTonic/flink outdate Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3071.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3071 commit 8c927bda55fead6b4cc90f49151c19907ac3700f Author: WangTaoTheTonic <wangtao111@huawei.com> Date: 2017-01-06T04:12:31Z fix the wrong config file name
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3071

          I use Illustrator‎ to edit svg file, which will add some header infos that cause CI failed. Is there any prefered svg editor?

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3071 I use Illustrator‎ to edit svg file, which will add some header infos that cause CI failed. Is there any prefered svg editor?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          you should be able to open the svg file with any text editor and add the license manually.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 you should be able to open the svg file with any text editor and add the license manually.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          I will take a look at these changes.

          Just a small note: We are not getting notified of pushed changes, a small comment is always good to get attention

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 I will take a look at these changes. Just a small note: We are not getting notified of pushed changes, a small comment is always good to get attention
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          When viewing the documentation in firefox there is now a lot of whitespace above the diagram. The dimensions have slightly changed as well :/

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 When viewing the documentation in firefox there is now a lot of whitespace above the diagram. The dimensions have slightly changed as well :/
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3071

          Hi @zentol , I've updated the svg using Inkscape.
          Is the whitespace you refer to on the topest(the red highlighted part)? I think it's normal as the original one has them to. It would not affect view in documents.
          ![default](https://cloud.githubusercontent.com/assets/5276001/21953009/8eef0426-da67-11e6-850a-935268ad019e.JPG)

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3071 Hi @zentol , I've updated the svg using Inkscape. Is the whitespace you refer to on the topest(the red highlighted part)? I think it's normal as the original one has them to. It would not affect view in documents. ! [default] ( https://cloud.githubusercontent.com/assets/5276001/21953009/8eef0426-da67-11e6-850a-935268ad019e.JPG )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          well that's the thing, i did rebuild the documentation and in the new version the whitespace was shown. The old version didn't have that. I'll try the updated version and will make screenshots if i see it again

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 well that's the thing, i did rebuild the documentation and in the new version the whitespace was shown. The old version didn't have that. I'll try the updated version and will make screenshots if i see it again
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          Nice, the updated version is better

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 Nice, the updated version is better
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3071

          I guess it is probably that the illustrator added sth.

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3071 I guess it is probably that the illustrator added sth.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3071

          Could be; it's a bit frightening to see how much the results differ based on which application one uses :/

          Anyway, I will add this to my batch of commits to merge. However, the massive diff drove me crazy, so I massaged the svg file a bit and the diff is now a bit smaller (see here: https://github.com/zentol/flink/commit/4c8d2bde83aeb9d066845c26ea937228d077f867). Hope you don't mind that.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3071 Could be; it's a bit frightening to see how much the results differ based on which application one uses :/ Anyway, I will add this to my batch of commits to merge. However, the massive diff drove me crazy, so I massaged the svg file a bit and the diff is now a bit smaller (see here: https://github.com/zentol/flink/commit/4c8d2bde83aeb9d066845c26ea937228d077f867 ). Hope you don't mind that.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user WangTaoTheTonic commented on the issue:

          https://github.com/apache/flink/pull/3071

          Surely not

          Show
          githubbot ASF GitHub Bot added a comment - Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3071 Surely not
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3071

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3071
          Hide
          Zentol Chesnay Schepler added a comment -

          master: 6c03491ce30ba3f31fb85ffb864731aa3f5aa482
          1.2: 7f20bd0d65cdce9e6180c20777959e4c522c55ce

          Show
          Zentol Chesnay Schepler added a comment - master: 6c03491ce30ba3f31fb85ffb864731aa3f5aa482 1.2: 7f20bd0d65cdce9e6180c20777959e4c522c55ce

            People

            • Assignee:
              Unassigned
              Reporter:
              WangTao Tao Wang
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development