Details

      Description

      Several RocksDB tests were previously disabled as they could not finish successfully. We recently upgraded our RocksDB version however which adds Windows support, so we should enable these tests again. I tried them already locally and they do in fact pass.

      Except one, which fails due to path normalization:

      RocksDBStateBackendConfigTest#testSetDbPath:
      arrays first differed at element [0]; 
      Expected :C:\Users\Zento\AppData\Local\Temp\junit842723791275019440\junit527481104946100979
      Actual   :C:/Users/Zento/AppData/Local/Temp/junit842723791275019440/junit527481104946100979
      
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3067

          FLINK-5412 Enable RocksDB tests on Windows OS

          This PR re-enables several RocksDB tests.

          Furthermore, the `RocksDBStateBackendConfigTest#testSetDbPath` was modified to ensure that hte same normalization is applied to both the expected and actual paths.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 5412_rocks_tests_enable

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3067.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3067


          commit 2dbc3c836ad42bbcfcc7264d1297fe876618d01c
          Author: zentol <chesnay@apache.org>
          Date: 2017-01-05T15:18:38Z

          FLINK-5412 Enable RocksDB tests on Windows OS


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3067 FLINK-5412 Enable RocksDB tests on Windows OS This PR re-enables several RocksDB tests. Furthermore, the `RocksDBStateBackendConfigTest#testSetDbPath` was modified to ensure that hte same normalization is applied to both the expected and actual paths. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 5412_rocks_tests_enable Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3067.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3067 commit 2dbc3c836ad42bbcfcc7264d1297fe876618d01c Author: zentol <chesnay@apache.org> Date: 2017-01-05T15:18:38Z FLINK-5412 Enable RocksDB tests on Windows OS
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3067#discussion_r94793743

          — Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java —
          @@ -42,6 +40,7 @@
          import org.rocksdb.DBOptions;

          import java.io.File;
          +import java.nio.file.Files;
          — End diff –

          Unused import?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3067#discussion_r94793743 — Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java — @@ -42,6 +40,7 @@ import org.rocksdb.DBOptions; import java.io.File; +import java.nio.file.Files; — End diff – Unused import?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3067#discussion_r94798431

          — Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java —
          @@ -42,6 +40,7 @@
          import org.rocksdb.DBOptions;

          import java.io.File;
          +import java.nio.file.Files;
          — End diff –

          yes, will fix it while merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3067#discussion_r94798431 — Diff: flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackendConfigTest.java — @@ -42,6 +40,7 @@ import org.rocksdb.DBOptions; import java.io.File; +import java.nio.file.Files; — End diff – yes, will fix it while merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3067

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3067 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3067

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3067
          Hide
          Zentol Chesnay Schepler added a comment -

          1.2: aaf9612791284633727a0951d0d45292ef5e233c
          1.3: e13ac598b48305080f19af32f475b95ab669dc3b

          Show
          Zentol Chesnay Schepler added a comment - 1.2: aaf9612791284633727a0951d0d45292ef5e233c 1.3: e13ac598b48305080f19af32f475b95ab669dc3b

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development