Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5402

Fails AkkaRpcServiceTest#testTerminationFuture

    Details

      Description

      testTerminationFuture(org.apache.flink.runtime.rpc.akka.AkkaRpcServiceTest)  Time elapsed: 1.013 sec  <<< ERROR!
      org.junit.runners.model.TestTimedOutException: test timed out after 1000 milliseconds
      	at sun.misc.Unsafe.park(Native Method)
      	at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
      	at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(AbstractQueuedSynchronizer.java:1037)
      	at java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(AbstractQueuedSynchronizer.java:1328)
      	at scala.concurrent.impl.Promise$DefaultPromise.tryAwait(Promise.scala:208)
      	at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:218)
      	at scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:223)
      	at scala.concurrent.Await$$anonfun$result$1.apply(package.scala:107)
      	at scala.concurrent.BlockContext$DefaultBlockContext$.blockOn(BlockContext.scala:53)
      	at scala.concurrent.Await$.result(package.scala:107)
      	at akka.remote.Remoting.start(Remoting.scala:179)
      	at akka.remote.RemoteActorRefProvider.init(RemoteActorRefProvider.scala:184)
      	at akka.actor.ActorSystemImpl.liftedTree2$1(ActorSystem.scala:620)
      	at akka.actor.ActorSystemImpl._start$lzycompute(ActorSystem.scala:617)
      	at akka.actor.ActorSystemImpl._start(ActorSystem.scala:617)
      	at akka.actor.ActorSystemImpl.start(ActorSystem.scala:634)
      	at akka.actor.ActorSystem$.apply(ActorSystem.scala:142)
      	at akka.actor.ActorSystem$.apply(ActorSystem.scala:119)
      	at akka.actor.ActorSystem$.create(ActorSystem.scala:67)
      	at org.apache.flink.runtime.akka.AkkaUtils$.createActorSystem(AkkaUtils.scala:104)
      	at org.apache.flink.runtime.akka.AkkaUtils$.createDefaultActorSystem(AkkaUtils.scala:114)
      	at org.apache.flink.runtime.akka.AkkaUtils.createDefaultActorSystem(AkkaUtils.scala)
      	at org.apache.flink.runtime.rpc.akka.AkkaRpcServiceTest.testTerminationFuture(AkkaRpcServiceTest.java:134)
      

      in org.apache.flink.runtime.rpc.akka.AkkaRpcServiceTest while testing current master 1.2.0 branch

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user dawidwys opened a pull request:

          https://github.com/apache/flink/pull/3343

          FLINK-5402 Fails AkkaRpcServiceTest#testTerminationFuture

          On macOS this test fails consistently as the actorSystem creation already causes timeout.
          Unfortunately the actorSystem and rpcService from the AkkaRpcServiceTest cannot be reused as this test terminates them (the test execution would depend on order).

          Other solution would be to remove this test completely.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/dawidwys/flink testFix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3343.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3343


          commit 07cb9b8e5283fbbc08517dff96a8236e44446c07
          Author: Dawid Wysakowicz <dawid@getindata.com>
          Date: 2017-02-17T11:27:19Z

          FLINK-5402 Fails AkkaRpcServiceTest#testTerminationFuture


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user dawidwys opened a pull request: https://github.com/apache/flink/pull/3343 FLINK-5402 Fails AkkaRpcServiceTest#testTerminationFuture On macOS this test fails consistently as the actorSystem creation already causes timeout. Unfortunately the actorSystem and rpcService from the AkkaRpcServiceTest cannot be reused as this test terminates them (the test execution would depend on order). Other solution would be to remove this test completely. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dawidwys/flink testFix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3343.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3343 commit 07cb9b8e5283fbbc08517dff96a8236e44446c07 Author: Dawid Wysakowicz <dawid@getindata.com> Date: 2017-02-17T11:27:19Z FLINK-5402 Fails AkkaRpcServiceTest#testTerminationFuture
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dawidwys closed the pull request at:

          https://github.com/apache/flink/pull/3343

          Show
          githubbot ASF GitHub Bot added a comment - Github user dawidwys closed the pull request at: https://github.com/apache/flink/pull/3343
          Hide
          dawidwys Dawid Wysakowicz added a comment - - edited

          It is very macOS specific case, due to very slow InetAddress.getLocalHost invocation. Can be resolved by binding 127.0.0.1 to one's hostname in /etc/hosts as described here: http://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds/33289897#33289897.

          The FLINK-5389 has exactly the same reason.

          Show
          dawidwys Dawid Wysakowicz added a comment - - edited It is very macOS specific case, due to very slow InetAddress.getLocalHost invocation. Can be resolved by binding 127.0.0.1 to one's hostname in /etc/hosts as described here: http://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds/33289897#33289897 . The FLINK-5389 has exactly the same reason.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user uce opened a pull request:

          https://github.com/apache/flink/pull/3430

          FLINK-5402 FLINK-5389 Increase test timeouts

          Some users reported running into timeouts due to too "aggressive" timeouts for certain configurations (as mentioned by Dawid in FLINK-5402).

          The changed timeouts don't affect the failure free runtime of the tests.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/uce/flink test_timeouts

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3430.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3430


          commit eed1ea009867675197a8cd1bf2b48df5e30d3e49
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-02-28T16:39:20Z

          FLINK-5402 [tests] Remove JUnit timeouts in AkkaRpcServiceTest

          commit e0eabe41a833228e10cb1ec7e6f3afa7c9bc00d9
          Author: Ufuk Celebi <uce@apache.org>
          Date: 2017-02-28T16:40:03Z

          FLINK-5389 [tests] Increate ask timeout in JobSubmitTest


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3430 FLINK-5402 FLINK-5389 Increase test timeouts Some users reported running into timeouts due to too "aggressive" timeouts for certain configurations (as mentioned by Dawid in FLINK-5402 ). The changed timeouts don't affect the failure free runtime of the tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/uce/flink test_timeouts Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3430.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3430 commit eed1ea009867675197a8cd1bf2b48df5e30d3e49 Author: Ufuk Celebi <uce@apache.org> Date: 2017-02-28T16:39:20Z FLINK-5402 [tests] Remove JUnit timeouts in AkkaRpcServiceTest commit e0eabe41a833228e10cb1ec7e6f3afa7c9bc00d9 Author: Ufuk Celebi <uce@apache.org> Date: 2017-02-28T16:40:03Z FLINK-5389 [tests] Increate ask timeout in JobSubmitTest
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3430#discussion_r103498419

          — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java —
          @@ -135,7 +135,7 @@ public void testGetAddress() {

          • @throws ExecutionException
          • @throws InterruptedException
            */
          • @Test(timeout = 1000)
            + @Test
              • End diff –

          @tillrohrmann Is is OK to remove these timeouts? We still catch this with the build timeout stack traces if no progress happens. As an alternative, we can increase the timeout to a higher value.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3430#discussion_r103498419 — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java — @@ -135,7 +135,7 @@ public void testGetAddress() { @throws ExecutionException @throws InterruptedException */ @Test(timeout = 1000) + @Test End diff – @tillrohrmann Is is OK to remove these timeouts? We still catch this with the build timeout stack traces if no progress happens. As an alternative, we can increase the timeout to a higher value.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3430#discussion_r103646797

          — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java —
          @@ -135,7 +135,7 @@ public void testGetAddress() {

          • @throws ExecutionException
          • @throws InterruptedException
            */
          • @Test(timeout = 1000)
            + @Test
              • End diff –

          It should be ok to remove the timeout, but I think that the build timeout stack traces are not so nice to see which test case actually caused the timeout. The reason for this is that there are multiple test cases being executed in parallel.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3430#discussion_r103646797 — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java — @@ -135,7 +135,7 @@ public void testGetAddress() { @throws ExecutionException @throws InterruptedException */ @Test(timeout = 1000) + @Test End diff – It should be ok to remove the timeout, but I think that the build timeout stack traces are not so nice to see which test case actually caused the timeout. The reason for this is that there are multiple test cases being executed in parallel.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3430#discussion_r103647638

          — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java —
          @@ -135,7 +135,7 @@ public void testGetAddress() {

          • @throws ExecutionException
          • @throws InterruptedException
            */
          • @Test(timeout = 1000)
            + @Test
              • End diff –

          OK, never noticed this problem, but will check it the next time. Maybe we can improve something. I'll leave the JUnit timeout and increase it to a higher value like 60000. I think that's a good compromise?

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/3430#discussion_r103647638 — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java — @@ -135,7 +135,7 @@ public void testGetAddress() { @throws ExecutionException @throws InterruptedException */ @Test(timeout = 1000) + @Test End diff – OK, never noticed this problem, but will check it the next time. Maybe we can improve something. I'll leave the JUnit timeout and increase it to a higher value like 60000. I think that's a good compromise?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3430#discussion_r103649079

          — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java —
          @@ -135,7 +135,7 @@ public void testGetAddress() {

          • @throws ExecutionException
          • @throws InterruptedException
            */
          • @Test(timeout = 1000)
            + @Test
              • End diff –

          yes

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3430#discussion_r103649079 — Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcServiceTest.java — @@ -135,7 +135,7 @@ public void testGetAddress() { @throws ExecutionException @throws InterruptedException */ @Test(timeout = 1000) + @Test End diff – yes
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3430

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3430
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 72f18dc (master).

          Show
          uce Ufuk Celebi added a comment - Fixed in 72f18dc (master).

            People

            • Assignee:
              dawidwys Dawid Wysakowicz
              Reporter:
              tonycox Anton Solovev
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development