Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5392

flink-dist build failed when change scala version to 2.11

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Build System
    • Labels:
      None
    • Environment:

      jdk 1.8.112

      Description

      when using
      tools/change-scala-version.sh 2.11
      then building will fail at flink-dist.
      Because some scala verion string is hard coded in flink-dist/src/main/assemblies/opt.xml.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3043

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3043
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via 7d1b9f0bb2dea719dc438cb8649f200cc6235980
          • 1.3.0 via 1358753dd9b830034593902531ed30e5557644f0
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via 7d1b9f0bb2dea719dc438cb8649f200cc6235980 1.3.0 via 1358753dd9b830034593902531ed30e5557644f0
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3043

          Thank you for creating this fix.

          I think this has already been subsumed by this commit https://github.com/apache/flink/commit/1358753dd9b830034593902531ed30e5557644f0

          Does this fix work for you? If yes, could you close the pull request?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3043 Thank you for creating this fix. I think this has already been subsumed by this commit https://github.com/apache/flink/commit/1358753dd9b830034593902531ed30e5557644f0 Does this fix work for you? If yes, could you close the pull request?
          Hide
          fhueske Fabian Hueske added a comment -

          There is another PR addressing this issue: https://github.com/apache/flink/pull/3047

          Show
          fhueske Fabian Hueske added a comment - There is another PR addressing this issue: https://github.com/apache/flink/pull/3047
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user whitelilis reopened a pull request:

          https://github.com/apache/flink/pull/3043

          FLINK-5392 flink-dist build failed when change scala version to 2.11

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/whitelilis/flink bugfix/flink-dist-opt-scala-version

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3043.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3043


          commit c41a5222e838fb0e015ca1a2b7cbcf70935d9f7f
          Author: whitelilis <liu.zhe@admaster.com.cn>
          Date: 2016-12-25T13:40:38Z

          change-scala-version.sh forget changing scala version in flink-dist/src/main/assemblies/opt.xml, build faild

          commit bacad6577274799906375397e57af7988b051f14
          Author: whitelilis <liu.zhe@admaster.com.cn>
          Date: 2016-12-25T13:43:44Z

          clear blank line


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user whitelilis reopened a pull request: https://github.com/apache/flink/pull/3043 FLINK-5392 flink-dist build failed when change scala version to 2.11 Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/whitelilis/flink bugfix/flink-dist-opt-scala-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3043.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3043 commit c41a5222e838fb0e015ca1a2b7cbcf70935d9f7f Author: whitelilis <liu.zhe@admaster.com.cn> Date: 2016-12-25T13:40:38Z change-scala-version.sh forget changing scala version in flink-dist/src/main/assemblies/opt.xml, build faild commit bacad6577274799906375397e57af7988b051f14 Author: whitelilis <liu.zhe@admaster.com.cn> Date: 2016-12-25T13:43:44Z clear blank line

            People

            • Assignee:
              Unassigned
              Reporter:
              liuzhe 刘喆
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development