Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5388

Remove private access of edges and vertices of Gelly Graph class

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.3
    • Fix Version/s: 1.3.0
    • Component/s: Gelly
    • Labels:
      None
    • Environment:

      Java

      Description

      If you want to make a special kind of Graph with special edge types or some different methods on top of Gelly you want to be able to extend the Graph class. Currently that's not possible because the constructor is private. I don't know what effect this has on other methods or the scale of the project, but it was just something that i ran into in my project

        Issue Links

          Activity

          Hide
          tonycox Anton Solovev added a comment -

          wouter ligtenberg could you provide an example of your necessity?

          Show
          tonycox Anton Solovev added a comment - wouter ligtenberg could you provide an example of your necessity?
          Hide
          otherwise777 wouter ligtenberg added a comment -

          I have created a Temporal graph tool on top of Gelly, on top of an edge label a temporal edge also has a starting and ending time. I have made several algorithms that use temporal graphs.

          I wanted to make a temporalGraph class that extends the Graph class such that i can easily make the gelly calls like numberOfVertices for instance.

          Also i think it should be usefull if later on other people want to add their own abstraction layer on top of Gelly

          Show
          otherwise777 wouter ligtenberg added a comment - I have created a Temporal graph tool on top of Gelly, on top of an edge label a temporal edge also has a starting and ending time. I have made several algorithms that use temporal graphs. I wanted to make a temporalGraph class that extends the Graph class such that i can easily make the gelly calls like numberOfVertices for instance. Also i think it should be usefull if later on other people want to add their own abstraction layer on top of Gelly
          Hide
          greghogan Greg Hogan added a comment -

          Is it sufficient to change Graph.<init>() to protected?

          Show
          greghogan Greg Hogan added a comment - Is it sufficient to change Graph.<init>() to protected ?
          Hide
          otherwise777 wouter ligtenberg added a comment -

          For my purpose, yes i think it is

          Show
          otherwise777 wouter ligtenberg added a comment - For my purpose, yes i think it is
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tonycox opened a pull request:

          https://github.com/apache/flink/pull/3044

          FLINK-5388 Change private Graph.<init>() to protected

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [ ] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [ ] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tonycox/flink privateGellyGraph

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3044.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3044


          commit ab47e060a2587cb9dec93d6d4e837ed0c61a0751
          Author: tonycox <anton_solovev@epam.com>
          Date: 2016-12-26T09:10:43Z

          change Graph.<init> to protected


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tonycox opened a pull request: https://github.com/apache/flink/pull/3044 FLINK-5388 Change private Graph.<init>() to protected Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [ ] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [ ] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/tonycox/flink privateGellyGraph Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3044.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3044 commit ab47e060a2587cb9dec93d6d4e837ed0c61a0751 Author: tonycox <anton_solovev@epam.com> Date: 2016-12-26T09:10:43Z change Graph.<init> to protected
          Hide
          otherwise777 wouter ligtenberg added a comment -

          What does this mean? That it will be implemented?

          Show
          otherwise777 wouter ligtenberg added a comment - What does this mean? That it will be implemented?
          Hide
          tonycox Anton Solovev added a comment -

          after reviewing this pull request by committers it will be implemented or declined in next version branch or other ones. for now to use the changes in your project you can pull privateGellyGraph branch from https://github.com/tonycox/

          Show
          tonycox Anton Solovev added a comment - after reviewing this pull request by committers it will be implemented or declined in next version branch or other ones. for now to use the changes in your project you can pull privateGellyGraph branch from https://github.com/tonycox/
          Hide
          otherwise777 wouter ligtenberg added a comment -

          Alright thnx!

          Show
          otherwise777 wouter ligtenberg added a comment - Alright thnx!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3044

          +1, I think this is a fair change

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3044 +1, I think this is a fair change Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3044

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3044
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via 986a03f782608532da45f5bff7c1b2f43a038bd1

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via 986a03f782608532da45f5bff7c1b2f43a038bd1

            People

            • Assignee:
              tonycox Anton Solovev
              Reporter:
              otherwise777 wouter ligtenberg
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development