Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5365

Mesos AppMaster/TaskManager should obey sigterm

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Cluster Management, Mesos
    • Labels:
      None

      Description

      The AppMaster and TaskManager are ignoring the sigterm sent by Marathon/Mesos. The reason is simply that the shell scripts used to start them don't pass the signal to java.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user EronWright opened a pull request:

          https://github.com/apache/flink/pull/3025

          FLINK-5365 Mesos AppMaster/TaskManager should obey sigterm

          Adjust bash script to propagate signals to the java process. This will allow Marathon to properly stop the JobManager.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/EronWright/flink feature-FLINK-5365

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3025.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3025


          commit 5bb42bde771a36d4bf0bcb769bcb60d7e45e6cfb
          Author: wrighe3 <eron.wright@emc.com>
          Date: 2016-12-19T01:20:53Z

          FLINK-5365 Mesos AppMaster/TaskManager should obey sigterm

          • use ‘exec’ in bash script to ensure that signals flow to the java
            process.

          Show
          githubbot ASF GitHub Bot added a comment - GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/3025 FLINK-5365 Mesos AppMaster/TaskManager should obey sigterm Adjust bash script to propagate signals to the java process. This will allow Marathon to properly stop the JobManager. You can merge this pull request into a Git repository by running: $ git pull https://github.com/EronWright/flink feature- FLINK-5365 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3025.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3025 commit 5bb42bde771a36d4bf0bcb769bcb60d7e45e6cfb Author: wrighe3 <eron.wright@emc.com> Date: 2016-12-19T01:20:53Z FLINK-5365 Mesos AppMaster/TaskManager should obey sigterm use ‘exec’ in bash script to ensure that signals flow to the java process.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3025

          Thanks for your contribution @EronWright. Really good fix Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3025 Thanks for your contribution @EronWright. Really good fix Merging this PR.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3025

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3025
          Hide
          till.rohrmann Till Rohrmann added a comment -

          1.3.0: Fixed via 5d0d279dc5d82fb63bc6cbd7c8fac2324959a516
          1.2.0: Fixed via e0a784197de6c6ff55d0d4e10d33199996240706

          Show
          till.rohrmann Till Rohrmann added a comment - 1.3.0: Fixed via 5d0d279dc5d82fb63bc6cbd7c8fac2324959a516 1.2.0: Fixed via e0a784197de6c6ff55d0d4e10d33199996240706

            People

            • Assignee:
              eronwright Eron Wright
              Reporter:
              eronwright Eron Wright
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development