Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5321

FlinkMiniCluster does not start Jobmanager MetricQueryService

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: JobManager, Metrics
    • Labels:
      None

      Description

      The JobManager MetricQueryService is never started when using the LocalFlinkMiniCluster. It lacks the call to MetricRegistry#startQueryService().

      As a result jobmanager metrics aren't reporter to the web frontend, and it causes repeated logging of exceptions.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/2991

          FLINK-5321 [metrics] LocalFlinkMiniCluster starts JM MetricQueryService

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 5321_mqs_fmc

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2991.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2991


          commit e943a2631c2750af9b1798c6a32929c3e3dac610
          Author: zentol <chesnay@apache.org>
          Date: 2016-12-12T17:15:14Z

          FLINK-5321 [metrics] LocalFlinkMiniCluster starts JM MetricQS


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/2991 FLINK-5321 [metrics] LocalFlinkMiniCluster starts JM MetricQueryService You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 5321_mqs_fmc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2991.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2991 commit e943a2631c2750af9b1798c6a32929c3e3dac610 Author: zentol <chesnay@apache.org> Date: 2016-12-12T17:15:14Z FLINK-5321 [metrics] LocalFlinkMiniCluster starts JM MetricQS
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2991

          Do we want this in case the mini cluster starts the web UI?

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2991 Do we want this in case the mini cluster starts the web UI?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2991

          We only need it in that case, yes.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2991 We only need it in that case, yes.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2991

          I can add a check for both the JM/TM to only start the service if the web UI is started as well.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2991 I can add a check for both the JM/TM to only start the service if the web UI is started as well.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2991

          I think that approach makes sense.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2991 I think that approach makes sense.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2991

          @StephanEwen Could you take another look?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2991 @StephanEwen Could you take another look?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/2991

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/2991 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2991

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2991
          Hide
          Zentol Chesnay Schepler added a comment -

          master: b36b43b9ad3f4b04a2a701b9139bb3eaf17b9ff8
          1.2: 2bbc92cf637b2caf612c43b0f35ba2282b5bc981

          Show
          Zentol Chesnay Schepler added a comment - master: b36b43b9ad3f4b04a2a701b9139bb3eaf17b9ff8 1.2: 2bbc92cf637b2caf612c43b0f35ba2282b5bc981

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development