Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-5277

missing unit test for ensuring ResultPartition#add always recycles buffers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0
    • Component/s: Network
    • Labels:
      None

      Description

      We rely on ResultPartition to recycle the buffer if the add calls fails.

      It makes sense to add a special test (to ResultPartitionTest or RecordWriterTest) where we ensure that this actually happens to guard against future behaviour changes in ResultPartition.

        Issue Links

          Activity

          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed via 1ceb7d82eccf4dc77482bddb61a664fd7f226b2b

          Show
          StephanEwen Stephan Ewen added a comment - Fixed via 1ceb7d82eccf4dc77482bddb61a664fd7f226b2b
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3309

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3309
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3309

          Good addition, thanks!
          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3309 Good addition, thanks! Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user NicoK opened a pull request:

          https://github.com/apache/flink/pull/3309

          FLINK-5277 add unit tests for ResultPartition#add() in case of failures

          This verifies that the given network buffer is recycled as expected and that
          no notifiers are called upon failures to add a buffer.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/NicoK/flink flink-5277

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3309.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3309


          commit dff30ab597065c3253018e2da353e6acbc5a5516
          Author: Nico Kruber <nico@data-artisans.com>
          Date: 2017-02-14T16:42:28Z

          FLINK-5277 add unit tests for ResultPartition#add() in case of failures

          This verifies that the given network buffer is recycled as expected and that
          no notifiers are called upon failures to add a buffer.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3309 FLINK-5277 add unit tests for ResultPartition#add() in case of failures This verifies that the given network buffer is recycled as expected and that no notifiers are called upon failures to add a buffer. You can merge this pull request into a Git repository by running: $ git pull https://github.com/NicoK/flink flink-5277 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3309.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3309 commit dff30ab597065c3253018e2da353e6acbc5a5516 Author: Nico Kruber <nico@data-artisans.com> Date: 2017-02-14T16:42:28Z FLINK-5277 add unit tests for ResultPartition#add() in case of failures This verifies that the given network buffer is recycled as expected and that no notifiers are called upon failures to add a buffer.

            People

            • Assignee:
              NicoK Nico Kruber
              Reporter:
              NicoK Nico Kruber
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development