Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-3656 Rework Table API tests
  3. FLINK-5268

Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      Currently the TableProgramsTestBase allows to run tests on a collection environment and a MiniCluster by setting a testing parameter. This was done to cover different execution path. However, testing on a MiniCluster is quite expensive and should only be done in rare cases.

      I propose to split the TableProgramsTestBase into

      • TableProgramsCollectionTestBase and
      • TableProgramsClusterTestBase

      to have the separation of both execution backends more clear.

        Issue Links

          Activity

          Hide
          twalthr Timo Walther added a comment -

          Fixed in 1.3.0: dba7d7da9b81fce21c13093634118a863a2e2bcc

          Show
          twalthr Timo Walther added a comment - Fixed in 1.3.0: dba7d7da9b81fce21c13093634118a863a2e2bcc
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3099

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3099
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/3099

          LGTM. Merging...

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3099 LGTM. Merging...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3099

          Thanks for the PR @mtunique.
          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3099 Thanks for the PR @mtunique. +1 to merge
          Hide
          jark Jark Wu added a comment - - edited

          Hi Fabian Hueske , do we have the case that an IT case should run both on collection environment and cluster environment ?

          And when should we use cluster environment ? To cover the combine phase is the only case I know. I think we should add some comments to remind developers when to use TableProgramsClusterTestBase .

          Show
          jark Jark Wu added a comment - - edited Hi Fabian Hueske , do we have the case that an IT case should run both on collection environment and cluster environment ? And when should we use cluster environment ? To cover the combine phase is the only case I know. I think we should add some comments to remind developers when to use TableProgramsClusterTestBase .
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mtunique opened a pull request:

          https://github.com/apache/flink/pull/3099

          FLINK-5268 Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase

          …TestBase and TableProgramsClusterTestBase

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mtunique/flink flink-5268

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3099.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3099


          commit a99b2bfe5a06677163cf62dcc6716bf641422d5e
          Author: mtunique <oatgnem@gmail.com>
          Date: 2017-01-12T09:30:57Z

          FLINK-5268 Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3099 FLINK-5268 Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase …TestBase and TableProgramsClusterTestBase Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink flink-5268 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3099.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3099 commit a99b2bfe5a06677163cf62dcc6716bf641422d5e Author: mtunique <oatgnem@gmail.com> Date: 2017-01-12T09:30:57Z FLINK-5268 Split TableProgramsTestBase into TableProgramsCollectionTestBase and TableProgramsClusterTestBase

            People

            • Assignee:
              Unassigned
              Reporter:
              fhueske Fabian Hueske
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development