Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Gelly
    • Labels:
      None

      Description

      The Gelly drivers started as simple wrappers around library algorithms but have grown to handle a matrix of input sources while often running multiple algorithms and analytics with custom parameterization.

      This ticket will refactor the sourcing of the input graph into separate classes for CSV files and RMat which will simplify the inclusion of new data sources.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3294

          FLINK-4949 [gelly] Refactor Gelly driver inputs

          The Gelly drivers started as simple wrappers around library algorithms but have grown to handle a matrix of input sources while often running multiple algorithms and analytics with custom parameterization.

          The monolithic drivers are replaced with separate inputs and algorithms. Command-line parameter parsers are shared and reusable across inputs and algorithms. Algorithm results now implement a common AlgorithmResult interface. Drivers are now tested with integration tests.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 4949_refactor_gelly_driver_inputs

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3294.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3294


          commit 523ed2dee670c818518397f42b6f2d7b61e95087
          Author: Greg Hogan <code@greghogan.com>
          Date: 2016-10-26T19:18:50Z

          FLINK-4949 [gelly] Refactor Gelly driver inputs

          The Gelly drivers started as simple wrappers around library algorithms
          but have grown to handle a matrix of input sources while often running
          multiple algorithms and analytics with custom parameterization.

          The monolithic drivers are replaced with separate inputs and algorithms.
          Command-line parameter parsers are shared and reusable across inputs and
          algorithms. Algorithm results now implement a common AlgorithmResult
          interface. Drivers are now tested with integration tests.

          commit 0b77619bace0059c536b2d4b57aaae28831c0951
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-02-11T15:35:36Z

          Refactor due to openjdk7 compile error.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3294 FLINK-4949 [gelly] Refactor Gelly driver inputs The Gelly drivers started as simple wrappers around library algorithms but have grown to handle a matrix of input sources while often running multiple algorithms and analytics with custom parameterization. The monolithic drivers are replaced with separate inputs and algorithms. Command-line parameter parsers are shared and reusable across inputs and algorithms. Algorithm results now implement a common AlgorithmResult interface. Drivers are now tested with integration tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 4949_refactor_gelly_driver_inputs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3294.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3294 commit 523ed2dee670c818518397f42b6f2d7b61e95087 Author: Greg Hogan <code@greghogan.com> Date: 2016-10-26T19:18:50Z FLINK-4949 [gelly] Refactor Gelly driver inputs The Gelly drivers started as simple wrappers around library algorithms but have grown to handle a matrix of input sources while often running multiple algorithms and analytics with custom parameterization. The monolithic drivers are replaced with separate inputs and algorithms. Command-line parameter parsers are shared and reusable across inputs and algorithms. Algorithm results now implement a common AlgorithmResult interface. Drivers are now tested with integration tests. commit 0b77619bace0059c536b2d4b57aaae28831c0951 Author: Greg Hogan <code@greghogan.com> Date: 2017-02-11T15:35:36Z Refactor due to openjdk7 compile error.
          Hide
          greghogan Greg Hogan added a comment -

          Vasia Kalavri, I have created PRs for sub-tasks 4, 5, and 6. Are you available to review?

          Show
          greghogan Greg Hogan added a comment - Vasia Kalavri , I have created PRs for sub-tasks 4, 5, and 6. Are you available to review?
          Hide
          vkalavri Vasia Kalavri added a comment - - edited

          Thank you Greg Hogan. I can review during the weekend.

          Show
          vkalavri Vasia Kalavri added a comment - - edited Thank you Greg Hogan . I can review during the weekend.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3294

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3294
          Hide
          greghogan Greg Hogan added a comment -

          Implemented in f1ff99fdc1e228acd936f5684832d5cf49bdbe04

          Show
          greghogan Greg Hogan added a comment - Implemented in f1ff99fdc1e228acd936f5684832d5cf49bdbe04

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development