Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4917

Deprecate "CheckpointedAsynchronously" interface

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0, 1.3.0
    • Component/s: Streaming
    • Labels:

      Description

      The CheckpointedAsynchronously should be deprecated, as it is no longer part of the new operator state abstraction.

        Issue Links

          Activity

          Hide
          heytitle Pattarawat Chormai added a comment -

          If I understand correctly, what we have to do here is to put @Deprecated annotation similar to https://git.io/vXvj4, am I correct?

          Anything else should be done?

          Show
          heytitle Pattarawat Chormai added a comment - If I understand correctly, what we have to do here is to put @Deprecated annotation similar to https://git.io/vXvj4 , am I correct? Anything else should be done?
          Hide
          fhueske Fabian Hueske added a comment -

          When deprecating interfaces it is good practice to add a comment about alternatives or workarounds (if there are any) or explain why the feature will be dropped. This helps users to rewrite their code.

          Show
          fhueske Fabian Hueske added a comment - When deprecating interfaces it is good practice to add a comment about alternatives or workarounds (if there are any) or explain why the feature will be dropped. This helps users to rewrite their code.
          Hide
          heytitle Pattarawat Chormai added a comment -

          Yeah, I'm also thinking about that. However, I'm quite new to Flink and actually never use this feature before, so could you please point me out to related issues in which I can sense what is the reasons behind?

          Show
          heytitle Pattarawat Chormai added a comment - Yeah, I'm also thinking about that. However, I'm quite new to Flink and actually never use this feature before, so could you please point me out to related issues in which I can sense what is the reasons behind?
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mtunique opened a pull request:

          https://github.com/apache/flink/pull/3087

          FLINK-4917 Deprecate "CheckpointedAsynchronously" interface

          • [x] General
          • The pull request references the related JIRA issue (FLINK-4917 Deprecate "CheckpointedAsynchronously" interface)
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mtunique/flink flink-4917

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3087.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3087


          commit e4ed2142447daf585cdd0c76fadc559429f8ac11
          Author: mtunique <oatgnem@gmail.com>
          Date: 2017-01-10T15:05:44Z

          FLINK-4917 Deprecate "CheckpointedAsynchronously" interface


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mtunique opened a pull request: https://github.com/apache/flink/pull/3087 FLINK-4917 Deprecate "CheckpointedAsynchronously" interface [x] General The pull request references the related JIRA issue ( FLINK-4917 Deprecate "CheckpointedAsynchronously" interface) The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtunique/flink flink-4917 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3087.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3087 commit e4ed2142447daf585cdd0c76fadc559429f8ac11 Author: mtunique <oatgnem@gmail.com> Date: 2017-01-10T15:05:44Z FLINK-4917 Deprecate "CheckpointedAsynchronously" interface
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3087

          Per Fabian's comment from the Jira, we should also document the deprecation in the javadoc with the recommended replacement functionality.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3087 Per Fabian's comment from the Jira, we should also document the deprecation in the javadoc with the recommended replacement functionality.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mtunique commented on the issue:

          https://github.com/apache/flink/pull/3087

          I am sorry about it.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 I am sorry about it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mtunique commented on the issue:

          https://github.com/apache/flink/pull/3087

          @greghogan I have add the javadoc about replacement. Maybe `Checkpointed` has the same problem about javadoc. Fix it in this PR or create a new issue on jira?

          Show
          githubbot ASF GitHub Bot added a comment - Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 @greghogan I have add the javadoc about replacement. Maybe `Checkpointed` has the same problem about javadoc. Fix it in this PR or create a new issue on jira?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3087

          I think this needs to also talk about the asynchrony, and the short cut replacement via `ListCheckpointed` etc.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3087 I think this needs to also talk about the asynchrony, and the short cut replacement via `ListCheckpointed` etc.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3087

          Thanks, much better now!
          Will merge this for 1.2 and master...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3087 Thanks, much better now! Will merge this for 1.2 and master...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mtunique commented on the issue:

          https://github.com/apache/flink/pull/3087

          Maybe we should open an issue about `Checkpointed` java doc to talk about how to replace the APIs.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3087 Maybe we should open an issue about `Checkpointed` java doc to talk about how to replace the APIs.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3087

          @mtunique I am addressing the `Checkpointed` in a quick followup to this pull request, pretty much copying the docs from `CheckpointedAsynchronously`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3087 @mtunique I am addressing the `Checkpointed` in a quick followup to this pull request, pretty much copying the docs from `CheckpointedAsynchronously`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3087

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3087
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.2.0 via 083152c63086e465b71c702815a2d22af686f122
          • 1.3.0 via 0d587ff861dbed10dd487886aab2eb83d8c2a443
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.2.0 via 083152c63086e465b71c702815a2d22af686f122 1.3.0 via 0d587ff861dbed10dd487886aab2eb83d8c2a443

            People

            • Assignee:
              Unassigned
              Reporter:
              StephanEwen Stephan Ewen
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development