[FLINK-4879] class KafkaTableSource should be public just like KafkaTableSink

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.1, 1.1.3
• Fix Version/s: 1.2.0
• Component/s: Connectors / Kafka, Table SQL / API
• Assignee: Unassigned
• Reporter: yuemeng
• Created: 21/Oct/16 09:41
• Updated: 25/Oct/16 18:56
• Resolved: 24/Oct/16 13:49

Description

class KafkaTableSource should be public just like KafkaTableSink,by default,it's modifier is default ，and we cann't access out of it's package,
for example:

def createKafkaTableSource(
      topic: String,
      properties: Properties,
      deserializationSchema: DeserializationSchema[Row],
      fieldsNames: Array[String],
      typeInfo: Array[TypeInformation[_]]): KafkaTableSource = {

    if (deserializationSchema != null) {
      new Kafka09TableSource(topic, properties, deserializationSchema, fieldsNames, typeInfo)
    } else {
      new Kafka09JsonTableSource(topic, properties, fieldsNames, typeInfo)
    }
  }

Because of the class KafkaTableSource modifier is default,we cann't define this function result type with KafkaTableSource ,we must give the specific type.
if some other kafka source extends KafkaTableSource ,and we don't sure which subclass of KafkaTableSource should be use,how can we specific the type?

Issue Links

• links to: GitHub Pull Request #2678