[FLINK-4701] Unprotected access to cancelables in StreamTask

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 27/Sep/16 18:03
• Updated: 12/Oct/16 18:15
• Resolved: 12/Oct/16 18:14

Description

In performCheckpoint():

                                AsyncCheckpointRunnable asyncCheckpointRunnable = new AsyncCheckpointRunnable(
                                                "checkpoint-" + checkpointId + "-" + timestamp,
                                                this,
                                                cancelables,
                                                chainedStateHandles,
                                                keyGroupsStateHandleFuture,
                                                checkpointId,
                                                bytesBufferedAlignment,
                                                alignmentDurationNanos,
                                                syncDurationMillis,
                                                endOfSyncPart);

                                synchronized (cancelables) {
                                        cancelables.add(asyncCheckpointRunnable);
                                }

Construction of AsyncCheckpointRunnable should be put under the synchronized block of cancelables.