Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4677

Jars with no job executions produces NullPointerException in ClusterClient

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.2
    • Fix Version/s: 1.2.0, 1.1.3
    • Component/s: Client
    • Labels:
      None

      Description

      When the user jar contains no job executions, the command-line client displays a NullPointerException. This is not a big issue but should be changed to something more descriptive.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user mxm opened a pull request:

          https://github.com/apache/flink/pull/2548

          FLINK-4677 fail if user jar contains no executions

          If the user has an empty main method with no Flink executions, this will print a nicer error message.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/mxm/flink FLINK-4677

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2548.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2548


          commit 55f8ff766674b7c112a364de287b30a7afa4a1ee
          Author: Maximilian Michels <mxm@apache.org>
          Date: 2016-09-26T13:00:32Z

          FLINK-4677 fail if user jar contains no executions


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2548 FLINK-4677 fail if user jar contains no executions If the user has an empty main method with no Flink executions, this will print a nicer error message. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mxm/flink FLINK-4677 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2548 commit 55f8ff766674b7c112a364de287b30a7afa4a1ee Author: Maximilian Michels <mxm@apache.org> Date: 2016-09-26T13:00:32Z FLINK-4677 fail if user jar contains no executions
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2548

          Looks good to me, +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2548 Looks good to me, +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/2548

          Do we have a standard way for user programs to print usage and exit without triggering this message? This is certainly preferable to the `NullPointerException`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2548 Do we have a standard way for user programs to print usage and exit without triggering this message? This is certainly preferable to the `NullPointerException`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user mxm commented on the issue:

          https://github.com/apache/flink/pull/2548

          That's a good point @greghogan. We don't have a standard way to print a usage message. A disadvantage of the approach in this PR is that we will display an error message which might actually mask any usage information printed. An alternative approach would be to simply exit (perhaps with a small hint). That might actually be nicer.

          Show
          githubbot ASF GitHub Bot added a comment - Github user mxm commented on the issue: https://github.com/apache/flink/pull/2548 That's a good point @greghogan. We don't have a standard way to print a usage message. A disadvantage of the approach in this PR is that we will display an error message which might actually mask any usage information printed. An alternative approach would be to simply exit (perhaps with a small hint). That might actually be nicer.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2548

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2548
          Hide
          mxm Maximilian Michels added a comment -

          master: 8c7c42f0e91aa3fa2016650e541bbb668e6b79db
          release-1.1: fddd89bcd59ca836568e647594061938ab905d7d

          Show
          mxm Maximilian Michels added a comment - master: 8c7c42f0e91aa3fa2016650e541bbb668e6b79db release-1.1: fddd89bcd59ca836568e647594061938ab905d7d

            People

            • Assignee:
              mxm Maximilian Michels
              Reporter:
              mxm Maximilian Michels
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development