Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4644

Deprecate "flink.base.dir.path" from ConfigConstants

    Details

    • Type: Wish
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.3.0
    • Component/s: Build System
    • Labels:
      None

      Description

      Flink's configuration entry "flink.base.dir.path" is not documented anywhere but present in ConfigConstants. It is set in the JobManager but it is not accessed anywhere in the code.

      I propose to deprecate the entry from ConfigConstants:

      public static final String FLINK_BASE_DIR_PATH_KEY = "flink.base.dir.path";

      I think this entry can only possibly be abused by users to write into the Flink base dir or rely on some structure of the directory (which is different for standalone, yarn/mesos). The only way i can see such a variable being useful if it is present in the form of an environment variable to make it available to other systems.

        Activity

        Hide
        StephanEwen Stephan Ewen added a comment -

        It was initially used by the web frontend, IIRC.

        +1 for deprecating it.

        Show
        StephanEwen Stephan Ewen added a comment - It was initially used by the web frontend, IIRC. +1 for deprecating it.
        Hide
        Zentol Chesnay Schepler added a comment -

        Fixed in 8780cb6c4fa05f7cd6167f1240d03f407d8d41ea.

        Show
        Zentol Chesnay Schepler added a comment - Fixed in 8780cb6c4fa05f7cd6167f1240d03f407d8d41ea.

          People

          • Assignee:
            StephanEwen Stephan Ewen
            Reporter:
            mxm Maximilian Michels
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development