Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4589

Fix Merging of Covering Window in MergingWindowSet

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.4, 1.2.0, 1.1.3
    • Component/s: DataStream API
    • Labels:
      None

      Description

      Right now, when a new window gets merged that covers all of the existing window MergingWindowSet does not correctly set the state window.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user aljoscha opened a pull request:

          https://github.com/apache/flink/pull/2476

          FLINK-4589 Fix Merging of Covering Window in MergingWindowSet

          This also adds two new test cases for that problem.

          R: @StephanEwen

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/aljoscha/flink fix-merging-set

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/2476.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #2476


          commit 2eec6ba7ab6acf55ead2ea395a33043c87d1c911
          Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
          Date: 2016-09-07T11:51:53Z

          FLINK-4589 Fix Merging of Covering Window in MergingWindowSet

          This also adds two new test cases for that problem.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2476 FLINK-4589 Fix Merging of Covering Window in MergingWindowSet This also adds two new test cases for that problem. R: @StephanEwen You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink fix-merging-set Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2476.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2476 commit 2eec6ba7ab6acf55ead2ea395a33043c87d1c911 Author: Aljoscha Krettek <aljoscha.krettek@gmail.com> Date: 2016-09-07T11:51:53Z FLINK-4589 Fix Merging of Covering Window in MergingWindowSet This also adds two new test cases for that problem.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/2476

          Looks good to me, merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2476 Looks good to me, merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/2476

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2476
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Ah good, I saw that you also put this on the 1.1 branch. Closing this issue now.

          Show
          aljoscha Aljoscha Krettek added a comment - Ah good, I saw that you also put this on the 1.1 branch. Closing this issue now.
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Fixed on master and release 1.1 branch.

          Show
          aljoscha Aljoscha Krettek added a comment - Fixed on master and release 1.1 branch.

            People

            • Assignee:
              aljoscha Aljoscha Krettek
              Reporter:
              aljoscha Aljoscha Krettek
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development