[FLINK-4573] Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 02/Sep/16 17:50
• Updated: 30/Sep/16 14:49
• Resolved: 30/Sep/16 14:49

Description

                                                try {
                                                        raf = new RandomAccessFile(file, "r");
                                                } catch (FileNotFoundException e) {
                                                        display(ctx, request, "Displaying TaskManager log failed.");
                                                        LOG.error("Displaying TaskManager log failed.", e);
                                                        return;
                                                }
                                                long fileLength = raf.length();
                                                final FileChannel fc = raf.getChannel();

If length() throws IOException, raf would be left unclosed.

Issue Links

• links to: GitHub Pull Request #2556