Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-4148

incorrect calculation distance in QuadTree

    Details

      Description

      https://github.com/apache/flink/blob/master/flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/nn/QuadTree.scala#L105

      Because EuclideanDistanceMetric extends SquaredEuclideanDistanceMetric we always move in first case and never reach case for math.sqrt(minDist)

      correct match first EuclideanDistanceMetric and after it SquaredEuclideanDistanceMetric

      p.s. because EuclideanDistanceMetric more compute expensive and stay as default DistanceMetric it's can cause some performance degradation for KNN on default parameters

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                humanoid Alexey Diomin
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: