[FLINK-4053] Return value from Connection should be checked against null

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Ivan Mushketyk
• Reporter: Ted Yu
• Created: 09/Jun/16 19:40
• Updated: 15/Jul/16 10:44
• Resolved: 15/Jul/16 10:19

Description

In RMQSource.java and RMQSink.java, there is code in the following pattern:

      connection = factory.newConnection();
      channel = connection.createChannel();

According to https://www.rabbitmq.com/releases/rabbitmq-java-client/current-javadoc/com/rabbitmq/client/Connection.html#createChannel() :

Returns:
a new channel descriptor, or null if none is available

The return value should be checked against null.

Issue Links

• links to: GitHub Pull Request #2128