Details

      Description

      Recently I submitted a formula for apache-flink to the homebrew project. Homebrew simplifies installation on Mac:

      $ brew install apache-flink
      ...
      $ flink --version
      Version: 1.0.2, Commit ID: d39af15
      

      Updates to the formula are adhoc at the moment. I opened this issue to formalize updating homebrew into the release process. I drafted a procedure doc here:
      https://gist.github.com/EronWright/b62bd3b192a15be4c200a2542f7c9376

      Please also consider updating the website documentation to suggest homebrew as an alternate installation method for Mac users.

        Issue Links

          Activity

          Hide
          mxm Maximilian Michels added a comment -

          Thanks for the formula! Updating the documentation is a good starter issue for new contributors.

          Show
          mxm Maximilian Michels added a comment - Thanks for the formula! Updating the documentation is a good starter issue for new contributors.
          Hide
          heytitle Pattarawat Chormai added a comment -

          Ufuk Celebi are you still working on the issue?

          Show
          heytitle Pattarawat Chormai added a comment - Ufuk Celebi are you still working on the issue?
          Hide
          uce Ufuk Celebi added a comment -

          No, just unassigned myself. Makes sense to wait until 1.2 is released and then update this.

          Show
          uce Ufuk Celebi added a comment - No, just unassigned myself. Makes sense to wait until 1.2 is released and then update this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user heytitle opened a pull request:

          https://github.com/apache/flink/pull/3393

          FLINK-3903[docs] adding alternative installation documentation for …

          …OSX users

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [x] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/heytitle/flink FLINK-3903-homebrew-installation

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3393.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3393


          commit 0539e3f72e19ba5523410b4b03bd446969c8fbb7
          Author: heytitle <pat.chormai@gmail.com>
          Date: 2017-02-22T16:04:42Z

          FLINK-3903[docs] adding alternative installation documentation for OSX users


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user heytitle opened a pull request: https://github.com/apache/flink/pull/3393 FLINK-3903 [docs] adding alternative installation documentation for … …OSX users Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [x] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/heytitle/flink FLINK-3903 -homebrew-installation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3393.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3393 commit 0539e3f72e19ba5523410b4b03bd446969c8fbb7 Author: heytitle <pat.chormai@gmail.com> Date: 2017-02-22T16:04:42Z FLINK-3903 [docs] adding alternative installation documentation for OSX users
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3393#discussion_r102515804

          — Diff: docs/quickstart/setup_quickstart.md —
          @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to
          ~~~

          {% endif %}

          +### Alternatively
          — End diff –

          What if we renamed "Alternatively" to "Install on MacOS".

          And perhaps pull the prior "Download" into the if/else and rename to "Download and Unpack" and "Download and Compile"?

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3393#discussion_r102515804 — Diff: docs/quickstart/setup_quickstart.md — @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to ~~~ {% endif %} +### Alternatively — End diff – What if we renamed "Alternatively" to "Install on MacOS". And perhaps pull the prior "Download" into the if/else and rename to "Download and Unpack" and "Download and Compile"?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user heytitle commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3393#discussion_r102675770

          — Diff: docs/quickstart/setup_quickstart.md —
          @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to
          ~~~

          {% endif %}

          +### Alternatively
          — End diff –

          Should we also put to OSX installation into the if/else?

          Show
          githubbot ASF GitHub Bot added a comment - Github user heytitle commented on a diff in the pull request: https://github.com/apache/flink/pull/3393#discussion_r102675770 — Diff: docs/quickstart/setup_quickstart.md — @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to ~~~ {% endif %} +### Alternatively — End diff – Should we also put to OSX installation into the if/else?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on a diff in the pull request:

          https://github.com/apache/flink/pull/3393#discussion_r102723574

          — Diff: docs/quickstart/setup_quickstart.md —
          @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to
          ~~~

          {% endif %}

          +### Alternatively
          — End diff –

          Yes. And perhaps use the `<div class="codetabs" markdown="1">` formatting as with `dataset_transformation.md` and elsewhere. With tabs it is easy to see the different choices.

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3393#discussion_r102723574 — Diff: docs/quickstart/setup_quickstart.md — @@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is installed to ~~~ {% endif %} +### Alternatively — End diff – Yes. And perhaps use the `<div class="codetabs" markdown="1">` formatting as with `dataset_transformation.md` and elsewhere. With tabs it is easy to see the different choices.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3393

          Looks good, merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3393 Looks good, merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3393

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3393
          Hide
          uce Ufuk Celebi added a comment -

          Fixed in 90173b7 (release-1.2), 87b9077 (master).

          Show
          uce Ufuk Celebi added a comment - Fixed in 90173b7 (release-1.2), 87b9077 (master).

            People

            • Assignee:
              Unassigned
              Reporter:
              eronwright Eron Wright
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development