[FLINK-36201] StateLocalitySlotAssigner should be only used when local recovery is enabled for Adaptive Scheduler

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0-preview
• Component/s: Runtime / Coordination
• Labels: pull-request-available
• Release Note: AdaptiveScheduler now respects `execution.state-recovery.from-local` flag, which defaults to false. As a result you now need to opt-in to make local recovery work.
• Assignee: Rui Fan
• Reporter: Rui Fan
• Created: 03/Sep/24 06:47
• Updated: 05/Sep/24 05:58
• Resolved: 04/Sep/24 06:49

Description

SlotSharingSlotAllocator created the StateLocalitySlotAssigner[1] instead of DefaultSlotAssigner whenever failover happens.

I'm curious why we use StateLocalitySlotAssigner when local recovery is disable. 

As I understand, the local recovery doesn't take effect if flink doesn't backup state on the TM local disk. So StateLocalitySlotAssigner should be only used when local recovery is enabled.

 

[1] https://github.com/apache/flink/blob/c869326d089705475481c2c2ea42a6efabb8c828/flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java#L136

Issue Links

• links to: GitHub Pull Request #25284