[FLINK-34522] StateTtlConfig#cleanupInRocksdbCompactFilter still uses the deprecated Time class

• Type: Improvement
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.19.0
• Fix Version/s: 1.19.0, 1.20.0
• Component/s: API / Core
• Labels: pull-request-available
• Assignee: Rui Fan
• Reporter: Rui Fan
• Created: 27/Feb/24 05:16
• Updated: 11/Mar/24 06:18
• Resolved: 11/Mar/24 06:18

Description

FLINK-32570 deprecated the Time class and refactor all Public or PublicEvolving apis to use the Java's Duration.

StateTtlConfig.Builder#cleanupInRocksdbCompactFilter is still using the Time class. In general, we expect:

• Mark cleanupInRocksdbCompactFilter(long, Time) as @Deprecated
• Provide a new cleanupInRocksdbCompactFilter(long, Duration)

Note: This is exactly what FLINK-32570 does, so I guess FLINK-32570 missed cleanupInRocksdbCompactFilter.

But I found this method is introduced in 1.19(FLINK-30854), so a better solution may be: only provide cleanupInRocksdbCompactFilter(long, Duration) and don't use Time.

The deprecated Api should be keep for 2 minor version. IIUC, we cannot remove Time related class in Flink 2.0 if we don't deprecate it in 1.19. If so, I think it's better to merge this JIRA in 1.19.0 as well.

Issue Links

• links to: GitHub Pull Request #24387
• links to: GitHub Pull Request #24417