[FLINK-31871] Interpret Flink MemoryUnits according to the actual user input

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: kubernetes-operator-1.7.0
• Component/s: API / Core, Kubernetes Operator
• Labels: pull-request-available
• Assignee: Praneeth Ramesh
• Reporter: Alexander Fedulov
• Created: 20/Apr/23 15:58
• Updated: 20/Nov/23 12:31
• Resolved: 20/Sep/23 05:56

Description

Currently all MemorySize.MemoryUnits are interpreted in "bibyte" notation, regardless of the units that users specify: https://github.com/apache/flink/blob/release-1.17/flink-core/src/main/java/org/apache/flink/configuration/MemorySize.java#L352-L356
(i.e. G = Gi)

Flink Kubernetes Operator utilizes these units for specifying resources in user-facing CR API (taskManager.resource.memory, jobManager.resource.memory). In other places this CR requires native K8S units specification (i.e. spec.containers[*].ephemeral-storage). 

There are two issues with this:

• users cannot rely on the same units notation (taskManager.resource.memory = 16Gi fails)
• taskManager.resource.memory = 16G is not interpreted as other units in the spec (16G is implicitly converted into 16Gi)

Issue Links

• links to: GitHub Pull Request #670