[FLINK-31377] BinaryArrayData getArray/getMap should Handle null correctly AssertionError: valueArraySize (-6) should >= 0

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.18.0
• Labels: auto-deprioritized-major pull-request-available
• Assignee: Unassigned
• Reporter: Jacky Lau
• Created: 09/Mar/23 08:48
• Updated: 02/Sep/23 22:35

Description

you can reproduce this error below. and reason is in ARRAY_CONTAINS

if the needle is a Map NOT NULL,and the array has null element.

this bellowing will cause getElementOrNull(ArrayData array, int pos) only can handle not null. so it throw exception
/*elementGetter = ArrayData.createElementGetter(needleDataType.getLogicalType());*/,

 

// code placeholder
Stream<TestSetSpec> getTestSetSpecs() {
    return Stream.of(
            TestSetSpec.forFunction(BuiltInFunctionDefinitions.ARRAY_CONTAINS)
                    .onFieldsWithData(
                            new Map[] {
                                null,
                                CollectionUtil.map(entry(1, "a"), entry(2, "b")),
                                CollectionUtil.map(entry(3, "c"), entry(4, "d")),
                            },
                            null)
                    .andDataTypes(
                            DataTypes.ARRAY(DataTypes.MAP(DataTypes.INT(), DataTypes.STRING())),
                            DataTypes.STRING())
                    .testResult(
                            $("f0").arrayContains(
                                            CollectionUtil.map(entry(3, "c"), entry(4, "d"))),
                            "ARRAY_CONTAINS(f0, MAP[3, 'c', 4, 'd'])",
                            true,
                            DataTypes.BOOLEAN()));
}

Issue Links

• links to: GitHub Pull Request #22143