[FLINK-31297] FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager unstable when running it a single time

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.17.0
• Fix Version/s: 1.17.0
• Component/s: Runtime / Coordination
• Labels: pull-request-available test-stability
• Assignee: !huwh
• Reporter: Matthias Pohl
• Created: 02/Mar/23 09:51
• Updated: 06/Mar/23 15:03
• Resolved: 06/Mar/23 13:30

Description

We noticed a weird test-instability in FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager when switching to sequential test execution (see FLINK-31278). I couldn't reproduce it in 1.16, therefore, marking it as a blocker for now. But it feels to be more of a test code issue.
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46671&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=9695

Mar 01 15:20:17 [ERROR] org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager  Time elapsed: 0.746 s  <<< FAILURE!
Mar 01 15:20:17 java.lang.AssertionError: 
Mar 01 15:20:17 
Mar 01 15:20:17 Expected size: 1 but was: 0 in:
Mar 01 15:20:17 []
Mar 01 15:20:17 	at org.apache.flink.runtime.resourcemanager.slotmanager.FineGrainedSlotManagerTest.testTaskManagerRegistrationDeductPendingTaskManager(FineGrainedSlotManagerTest.java:209)
Mar 01 15:20:17 

Issue Links

• Discovered while testing: FLINK-31278 exit code 137 (i.e. OutOfMemoryError) in core module
• is caused by: FLINK-18229 Pending worker requests should be properly cleared
• links to: GitHub Pull Request #22083