[FLINK-31208] KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)

• Type: Improvement
• Status: Resolved
• Priority: Not a Priority
• Resolution: Fixed
• Affects Version/s: kafka-3.0.0
• Fix Version/s: kafka-3.0.1
• Component/s: Connectors / Kafka
• Labels: pull-request-available starter
• Assignee: Hongshun Wang
• Reporter: Hongshun Wang
• Created: 24/Feb/23 06:37
• Updated: 09/Aug/23 04:27
• Resolved: 14/Mar/23 09:14

Description

KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits) ，which is no difference with its Parent class (SourceReaderBase). why not remove this override method?

 

Relative code is here, which we can see is no difference?

//org.apache.flink.connector.kafka.source.reader.KafkaSourceReader#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
} 

//org.apache.flink.connector.base.source.reader.SourceReaderBase#pauseOrResumeSplits
@Override
public void pauseOrResumeSplits(
        Collection<String> splitsToPause, Collection<String> splitsToResume) {
    splitFetcherManager.pauseOrResumeSplits(splitsToPause, splitsToResume);
}

Issue Links

• links to: GitHub Pull Request #26