Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-30109

Checked exceptions are sneakingly transformed into unchecked exceptions in the Pulsar

    XMLWordPrintableJSON

Details

    Description

      PulsarExceptionUtils provides sneaky* utility methods for hiding checked exceptions. This is rather unusual coding. Based on what's provided in the code I would have concerns as a reader that we're not handling errors properly in calling code.

      Either, we remove these methods and add proper exception handling or we add proper documentation on why this workaround is necessary.

      syhily already hinted in his FLINK-29830 PR comment that this is related to flaws of the Pulsar API.

      Attachments

        Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents the functions of the product. FLINK-29830 PulsarSinkITCase$DeliveryGuaranteeTest.writeRecordsToPulsar failed

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved
          is caused by

          Sub-task - The sub-task of the issue FLINK-20731 Pulsar Source

          • Major - Major loss of function.
          • Resolved
          Testing discovered

          Improvement - An improvement or enhancement to an existing feature or task. FLINK-31014 Expose exceptions in connector testing framework

          • Major - Major loss of function.
          • Open
          links to

          Web Link GitHub Pull Request #24

          Activity

            People

              syhily Yufan Sheng
              mapohl Matthias Pohl
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: