[FLINK-29124] Redundant checkNotNull in cli Package

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Component/s: Command Line Client
• Assignee: Unassigned
• Reporter: ivan Qing
• Created: 27/Aug/22 05:19
• Updated: 27/Oct/22 07:39
• Resolved: 27/Oct/22 07:39

Description

Redundant NotNull checks in function cli/CliFrontend.
getEffectiveConfiguration():

final ExecutionConfigAccessor executionParameters =                
ExecutionConfigAccessor.fromProgramOptions(
checkNotNull(programOptions), checkNotNull(jobJars));
 

while ExecutionConfigAccessor.fromProgramOptions indeed does the notNull check

public static <T> ExecutionConfigAccessor fromProgramOptions(
            final ProgramOptions options, 
                  final List<T> jobJars) {        
checkNotNull(options);       
checkNotNull(jobJars);
...
} 

I have searched other ExecutionConfigAccessor.fromProgramOptions() usages, and all of them do not use checkNotNull in invokion