Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-2908

Web interface redraw web plan when browser resized

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Implemented
    • Affects Version/s: 0.10.0
    • Fix Version/s: 1.3.0
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      The job plan graph does not resize when the user expands the browser window (only a change in width matters).

      To reproduce: 1) open the plan tab of a running or completed job in a non-maximized browser window (not full width), 2) maximize the browser window.

      Workaround: refresh the web page.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/3251

          FLINK-2908 [web frontend] Redraw web plan when browser resized

          Redraw the job plan visual graph when the browser width is increased.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 2908_web_interface_redraw_web_plan_when_resized

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3251.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3251


          commit 085fcac0414f536806e7d9e48454fe457cfee4fd
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-02-01T21:56:03Z

          FLINK-2908 [web frontend] Redraw web plan when browser resized

          Redraw the job plan visual graph when the browser width is increased.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/3251 FLINK-2908 [web frontend] Redraw web plan when browser resized Redraw the job plan visual graph when the browser width is increased. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 2908_web_interface_redraw_web_plan_when_resized Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3251 commit 085fcac0414f536806e7d9e48454fe457cfee4fd Author: Greg Hogan <code@greghogan.com> Date: 2017-02-01T21:56:03Z FLINK-2908 [web frontend] Redraw web plan when browser resized Redraw the job plan visual graph when the browser width is increased.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3251

          Hey Greg, I checked out the PR and still had the behaviour described in the JIRA (checked with Firefox and Chrome). Note that refreshing the page after resizing does also not change anything for me. There is a high chance that my setup is causing this, but is there a way to double check this? Could you maybe post a screenshot of the expected output after resizing the width (w/o refreshing) comparing it to the non-fixed version?

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3251 Hey Greg, I checked out the PR and still had the behaviour described in the JIRA (checked with Firefox and Chrome). Note that refreshing the page after resizing does also not change anything for me. There is a high chance that my setup is causing this, but is there a way to double check this? Could you maybe post a screenshot of the expected output after resizing the width (w/o refreshing) comparing it to the non-fixed version?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3251

          @uce thanks for looking at this and my apologies for not including screenshots. I am also using Firefox. An explicit page reload should force page assets to be redownloaded.

          Currently switching browser to fullscreen does not resize the job graph SVG:
          ![screen shot 2017-02-03 at 15 03 13](https://cloud.githubusercontent.com/assets/569655/22606659/9e59ac48-ea22-11e6-940d-9c4fcd235962.png)

          With this PR the SVG is resized to fill the space:
          ![screen shot 2017-02-03 at 15 07 58](https://cloud.githubusercontent.com/assets/569655/22606666/a38a8cb4-ea22-11e6-9c4b-403d61879a4b.png)

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3251 @uce thanks for looking at this and my apologies for not including screenshots. I am also using Firefox. An explicit page reload should force page assets to be redownloaded. Currently switching browser to fullscreen does not resize the job graph SVG: ! [screen shot 2017-02-03 at 15 03 13] ( https://cloud.githubusercontent.com/assets/569655/22606659/9e59ac48-ea22-11e6-940d-9c4fcd235962.png ) With this PR the SVG is resized to fill the space: ! [screen shot 2017-02-03 at 15 07 58] ( https://cloud.githubusercontent.com/assets/569655/22606666/a38a8cb4-ea22-11e6-9c4b-403d61879a4b.png )
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user uce commented on the issue:

          https://github.com/apache/flink/pull/3251

          Thanks for the screenshots. My job was simple too narrow (not enough operators). After trying with a job that has more operators, I could reproduce the fix. Initially, I though that redrawing meant "zooming in" to fill the preview window.

          +1 to merge, great fix!

          Show
          githubbot ASF GitHub Bot added a comment - Github user uce commented on the issue: https://github.com/apache/flink/pull/3251 Thanks for the screenshots. My job was simple too narrow (not enough operators). After trying with a job that has more operators, I could reproduce the fix. Initially, I though that redrawing meant "zooming in" to fill the preview window. +1 to merge, great fix!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3251

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3251
          Hide
          greghogan Greg Hogan added a comment -

          Implemented in d88c938cf04cd438db0f084bd670894d2eadcff2

          Show
          greghogan Greg Hogan added a comment - Implemented in d88c938cf04cd438db0f084bd670894d2eadcff2

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development