[FLINK-28109] Delete useful code in the row emitter.

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.15.0
• Fix Version/s: 1.20.0
• Component/s: Connectors / ElasticSearch
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Luning Wang
• Created: 17/Jun/22 09:27
• Updated: 11/Mar/24 12:44

Description

 

The `.id(key)` in the RowElasticsearchEmitter make users get confused.

The following is the source code. key always null, we can never call the `id` method.

if (key != null) {
    final UpdateRequest updateRequest =
            new UpdateRequest(indexGenerator.generate(row), documentType, key)
                    .doc(document, contentType)
                    .upsert(document, contentType);
    indexer.add(updateRequest);
} else {
    final IndexRequest indexRequest =
            new IndexRequest(indexGenerator.generate(row), documentType)
                    .id(key)
                    .source(document, contentType);
    indexer.add(indexRequest);
}

 

 

Issue Links

• links to: GitHub Pull Request #21
• links to: GitHub Pull Request #20004