Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-27886

Error way for skipping shade plugin in sub-modules

    XMLWordPrintableJSON

Details

    Description

      Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this

      <plugin>
      				<groupId>org.apache.maven.plugins</groupId>
      				<artifactId>maven-shade-plugin</artifactId>
      				<executions>
      					<execution>
      						</phase>
      					</execution>
      				</executions>
      			</plugin>
      

      It just set none phase for itself, can't forbid the inherited parent shade.


      the correct way is

      <plugin>
      				<groupId>org.apache.maven.plugins</groupId>
      				<artifactId>maven-shade-plugin</artifactId>
      				<executions>
      					<execution>
      						<id>shade-flink</id>
      						<phase>none</phase>
      					</execution>
      				</executions>
      			</plugin>
      

      it can forbid parent shade-flink and also it's own shade. because there are no extra own shade executions.

      Attachments

        1. screenshot-1.png
          63 kB
          Ran Tao
        2. screenshot-2.png
          112 kB
          Ran Tao

        Issue Links

          Activity

            People

              Unassigned Unassigned
              lemonjing Ran Tao
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: