[FLINK-27886] Error way for skipping shade plugin in sub-modules

• Type: Improvement
• Status: Open
• Priority: Not a Priority
• Resolution: Unresolved
• Affects Version/s: 1.13.6, 1.14.4, 1.15.0
• Component/s: BuildSystem / Shaded
• Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available
• Assignee: Unassigned
• Reporter: Ran Tao
• Created: 02/Jun/22 15:07
• Updated: 19/Aug/23 10:35

Description

Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this

<plugin>
				<groupId>org.apache.maven.plugins</groupId>
				<artifactId>maven-shade-plugin</artifactId>
				<executions>
					<execution>
						</phase>
					</execution>
				</executions>
			</plugin>

It just set none phase for itself, can't forbid the inherited parent shade.

the correct way is

<plugin>
				<groupId>org.apache.maven.plugins</groupId>
				<artifactId>maven-shade-plugin</artifactId>
				<executions>
					<execution>
						<id>shade-flink</id>
						<phase>none</phase>
					</execution>
				</executions>
			</plugin>

it can forbid parent shade-flink and also it's own shade. because there are no extra own shade executions.

Issue Links

• is duplicated by: FLINK-27899 deactivate the shade plugin doesn't take effect
• links to: GitHub Pull Request #19871