Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-27886

Error way for skipping shade plugin in sub-modules

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Currently in some sub-modules, for example, flink-quickstart-java flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error way like this

      <plugin>
      				<groupId>org.apache.maven.plugins</groupId>
      				<artifactId>maven-shade-plugin</artifactId>
      				<executions>
      					<execution>
      						</phase>
      					</execution>
      				</executions>
      			</plugin>
      

      It just set none phase for itself, can't forbid the inherited parent shade.


      the correct way is

      <plugin>
      				<groupId>org.apache.maven.plugins</groupId>
      				<artifactId>maven-shade-plugin</artifactId>
      				<executions>
      					<execution>
      						<id>shade-flink</id>
      						<phase>none</phase>
      					</execution>
      				</executions>
      			</plugin>
      

      it can forbid parent shade-flink and also it's own shade. because there are no extra own shade executions.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            lemonjing Ran Tao

            Dates

              Created:
              Updated:

              Slack

                Issue deployment