[FLINK-27187] The attemptsPerUpload metric may be lower than it actually is

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.16.0
• Component/s: Runtime / Metrics, Runtime / State Backends
• Labels: pull-request-available
• Assignee: Feifan Wang
• Reporter: Feifan Wang
• Created: 11/Apr/22 16:36
• Updated: 22/Apr/22 14:54
• Resolved: 22/Apr/22 14:54

Description

The attemptsPerUpload metric in ChangelogStorageMetricGroup indicate distributions of number of attempts per upload.

In the current implementation, each successful attempt try to update attemptsPerUpload with its attemptNumber.

But consider this case: 

1. attempt 1 timeout, then schedule attempt 2
2. attempt 1 completed before attempt 2 and update attemptsPerUpload with 1

In fact there are two attempts, but attemptsPerUpload updated with 1.

So, I think we should add "actionAttemptsCount" to RetryExecutor.RetriableActionAttempt, this field shared across all attempts to execute the same upload action representing the number of upload attempts. And completed attempt should use this field update attemptsPerUpload.

 

How do you think about ? ym , roman 

Issue Links

• links to: GitHub Pull Request #19441