[FLINK-26993] CheckpointCoordinatorTest#testMinCheckpointPause

• Type: Technical Debt
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.1, 1.16.0
• Component/s: Runtime / Checkpointing, Tests
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 01/Apr/22 20:05
• Updated: 13/Jul/22 02:34
• Resolved: 07/Apr/22 13:25

Description

The test triggers checkpoints, waits for the CC to have stored a pending checkpoint, and then sends an acknowledge.
The acknowledge can fail with an NPE because the PendingCheckpoint#checkpointTargetLocation hasn't been set yet. This doesn't happen synchronously with the PendingCheckpoint being added to CheckpointCoordinator#pendingCheckpoints.

Apr 01 19:57:36 [ERROR] org.apache.flink.runtime.checkpoint.CheckpointCoordinatorTest.testMinCheckpointPause  Time elapsed: 0.012 s  <<< ERROR!
Apr 01 19:57:36 org.apache.flink.runtime.checkpoint.CheckpointException: Could not finalize the pending checkpoint 1. Failure reason: Failure to finalize checkpoint.
Apr 01 19:57:36 	at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.finalizeCheckpoint(CheckpointCoordinator.java:1354)
Apr 01 19:57:36 	at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.completePendingCheckpoint(CheckpointCoordinator.java:1241)
Apr 01 19:57:36 	at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
...
Apr 01 19:57:36 Caused by: java.lang.NullPointerException
Apr 01 19:57:36 	at org.apache.flink.runtime.checkpoint.PendingCheckpoint.finalizeCheckpoint(PendingCheckpoint.java:327)
Apr 01 19:57:36 	at org.apache.flink.runtime.checkpoint.CheckpointCoordinator.finalizeCheckpoint(CheckpointCoordinator.java:1337)
Apr 01 19:57:36 	... 50 more

Issue Links

• blocks: FLINK-26995 Enable fork-reuse for all unit tests
• is caused by: FLINK-26049 The tolerable-failed-checkpoints logic is invalid when checkpoint trigger failed
• is duplicated by: FLINK-27216 CheckpointCoordinatorTest.testMinCheckpointPause failed on azure
• links to: GitHub Pull Request #19356
• links to: GitHub Pull Request #19865