[FLINK-26390] InputStream is not closed at CliClient#executeFile

• Type: Technical Debt
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.17.0
• Component/s: Table SQL / Client
• Labels: auto-deprioritized-major pull-request-available
• Assignee: Sergey Nuyanzin
• Reporter: Sergey Nuyanzin
• Created: 28/Feb/22 08:48
• Updated: 28/Oct/22 05:44
• Resolved: 28/Oct/22 05:42

Description

There is InputStream created however not closed

https://github.com/apache/flink/blob/e2463ddace26601c6442dbaa68c198a27c9cfbcf/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java#L349-L364

Another thing, which is easy to fix: it seems there is no need to create completer object for CliClient#executeFile since it makes sense only in interactive mode

It seems the reason is https://github.com/apache/flink/pull/18363/files

Issue Links

• links to: GitHub Pull Request #18927