[FLINK-26341] ZooKeeperTestEnvironment does not allow for repeated test execution

• Type: Bug
• Status: Resolved
• Priority: Not a Priority
• Resolution: Fixed
• Affects Version/s: 1.13.6, 1.14.3, 1.15.0
• Fix Version/s: 1.19.0
• Component/s: Runtime / Coordination
• Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available test-stability
• Assignee: Rui Fan
• Reporter: Matthias Pohl
• Created: 23/Feb/22 16:59
• Updated: 30/Aug/23 14:18
• Resolved: 30/Aug/23 14:01

Description

ZooKeeperTestEnvironment.deleteAll fails when rerunning a test due to the client not being started:

java.lang.IllegalStateException: Client is not started
	at org.apache.flink.shaded.curator5.org.apache.curator.shaded.com.google.common.base.Preconditions.checkState(Preconditions.java:507)
	at org.apache.flink.shaded.curator5.org.apache.curator.CuratorZookeeperClient.getZooKeeper(CuratorZookeeperClient.java:139)
	at org.apache.flink.runtime.zookeeper.ZooKeeperTestEnvironment.deleteAll(ZooKeeperTestEnvironment.java:145)
	at org.apache.flink.runtime.checkpoint.ZooKeeperCheckpointIDCounterITCase.cleanUp(ZooKeeperCheckpointIDCounterITCase.java:48)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	[...]

This behavior was observed when running various tests with repeat-until-failure enabled in Intellij:

• ZooKeeperCheckpointIDCounterITCase.testShutdownRemovesState
• ZooKeeperStateHandleStoreTest.testAddAndLock
• ZooKeeperStateHandleStoreTest.testFailingAddWithPossiblyInconsistentState

I'd assume that this applies in any other case as well.

Issue Links

• links to: GitHub Pull Request #23295