[FLINK-2621] Add support for positional arguments to ParameterTool

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 0.9
• Component/s: flink-contrib
• Assignee: Unassigned
• Reporter: Behrouz Derakhshan
• Created: 04/Sep/15 12:12
• Updated: 23/Apr/21 13:54

Description

While working on FLINK-2021, we noticed we need to have support for positional arguments, since after FLINK-2021 is merged, all training materials and guides that are pointing to the old way of executing the examples will not work.

What I have in mind is something like this:

// ------------------ Constructors ------------------------
	public static ParameterTool fromArgs(String[] args) {
		isPositional = true;
		// check if arg type is positional
		for(String arg:args){
			if (arg.contains("--")){
				isPositional = false;
			}
		}
		if(isPositional){
			return fromPositionalArgument(args);
		}
		...
	// create ParameterTool for positional arguments
	public static ParameterTool fromPositionalArgument(String[] args){
		return new ParameterTool(args);
	}

		...
	// underlying storage for arguments 
	private String[] dataPositional;
	private ParameterTool(String[] args){
		this.dataPositional = args;
	}
	// return the positional argument based on the given index
	public String get(int position){
		if(!isPositional){
			throw new RuntimeException("Arguments are of type of key, value");
		}
		return dataPositional[position];
	}