Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-16835 Replace TableConfig with Configuration
  3. FLINK-26190

Remove getTableConfig from ExecNodeConfiguration

    XMLWordPrintableJSON

Details

    Description

      Currently, ExecNodeConfig holds TableConfig instead of ReadableConfig for the configuration coming from the planner, because it's used by

      CommonPythonUtil#getMergedConfig. This should be fixed, so that CommonPythonUtil#getMergedConfig cam use a ReadableConfig instead, and then we can pass the ExecNodeConfig which holds the complete view of Planner's TableConfig + the ExecNode's persistedConfig.

       

      To achieve that the getMergedConfig methods of PythonConfigUtil must be changed, and also the temp solution in 

      PythonFunctionFactory#getPythonFunction must be changed as well:

      if (config instanceof TableConfig) {
          PythonDependencyUtils.merge(mergedConfig, ((TableConfig) config).getConfiguration());
      } else {
          PythonDependencyUtils.merge(mergedConfig, (Configuration) config);
      }

      Attachments

        Issue Links

          Activity

            People

              dianfu Dian Fu
              matriv Marios Trivyzas
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: