[FLINK-26049] The tolerable-failed-checkpoints logic is invalid when checkpoint trigger failed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.13.5, 1.14.3
• Fix Version/s: 1.14.5, 1.15.0
• Component/s: Runtime / Checkpointing
• Labels: pull-request-available
• Assignee: Rui Fan
• Reporter: Rui Fan
• Created: 09/Feb/22 10:12
• Updated: 07/Apr/22 13:09
• Resolved: 04/Mar/22 09:21

Description

After triggerCheckpoint, if checkpoint failed, flink will execute the tolerable-failed-checkpoints logic. But if triggerCheckpoint failed, flink won't execute the tolerable-failed-checkpoints logic.

How to reproduce this issue?

In our online env, hdfs sre deletes the flink base dir by mistake, and flink job don't have permission to create checkpoint dir. So cause flink trigger checkpoint failed.

There are some didn't meet expectations:

• JM just log "Failed to trigger checkpoint for job 6f09d4a15dad42b24d52c987f5471f18 since Trigger checkpoint failure" . Don't show the root cause or exception.
• user set tolerable-failed-checkpoints=0, but if triggerCheckpoint failed, flink won't execute the tolerable-failed-checkpoints logic. 
• When triggerCheckpoint failed, numberOfFailedCheckpoints is always 0
• When triggerCheckpoint failed, we can't find checkpoint info in checkpoint history page.

 

 

 

All metrics are normal, so the next day we found out that the checkpoint failed, and the checkpoint has been failing for a day. it's not acceptable to the flink user.

I have some ideas:

1. Should tolerable-failed-checkpoints logic be executed when triggerCheckpoint fails?
2. When triggerCheckpoint failed, should increase numberOfFailedCheckpoints?
3. When triggerCheckpoint failed, should show checkpoint info in checkpoint history page?
4. JM just show "Failed to trigger checkpoint", should we show detailed exception to easy find the root cause?

 

Masters, could we do these changes? Please correct me if I'm wrong.

Issue Links

• causes: FLINK-26550 Correct the information of checkpoint failure
• causes: FLINK-26993 CheckpointCoordinatorTest#testMinCheckpointPause
• is duplicated by: FLINK-24384 Count checkpoints failed in trigger phase into numberOfFailedCheckpoints
• links to: GitHub Pull Request #18852
• links to: GitHub Pull Request #18941